Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying Nomic Visualizations #72

Merged
merged 65 commits into from
Sep 15, 2023
Merged

Modifying Nomic Visualizations #72

merged 65 commits into from
Sep 15, 2023

Conversation

star-nox
Copy link
Member

No description provided.

@star-nox star-nox self-assigned this Aug 29, 2023
@lintrule-review
Copy link

You need to setup a payment method to use Lintrule

You can fix that by putting in a card here.

@railway-app
Copy link

railway-app bot commented Aug 29, 2023

This PR is being deployed to Railway 🚅

flask: ◻️ REMOVED

@KastanDay
Copy link
Member

KastanDay commented Aug 30, 2023

Thank you this is wonderful.

Edit: omg I'm impressed, you literally followed every best practice for every line you committed in the PR. Thank you for such high quality Python in the /onResponseCompletion endpoint.

I'll make it my top priority tomorrow to call your new endpoint from the front end so you can test.

@star-nox
Copy link
Member Author

Re-did maps to include model responses for all courses except 2, they had a lot of data and I was hitting rate limit errors on openAI. Will try those again later.

@star-nox
Copy link
Member Author

star-nox commented Sep 1, 2023

Re-did maps to include model responses for all courses except 2, they had a lot of data and I was hitting rate limit errors on openAI. Will try those again later.

All the maps are updated to reflect both query and response.

@KastanDay
Copy link
Member

Re-did maps to include model responses for all courses except 2, they had a lot of data and I was hitting rate limit errors on openAI. Will try those again later.

All the maps are updated to reflect both query and response.

Is this expected behavior?
CleanShot 2023-09-01 at 10 44 37

CleanShot 2023-09-01 at 10 45 10

@star-nox
Copy link
Member Author

star-nox commented Sep 1, 2023

Re-did maps to include model responses for all courses except 2, they had a lot of data and I was hitting rate limit errors on openAI. Will try those again later.

All the maps are updated to reflect both query and response.

Is this expected behavior? CleanShot 2023-09-01 at 10 44 37

CleanShot 2023-09-01 at 10 45 10

These are the old links. I haven't updated the new map links in getMaps() function because we are still logging only user queries on prod. I was hoping to test your frontend endpoint and push everything together.

@KastanDay
Copy link
Member

Oh okay, thank you. I'll really try to finish those endpoints today. Sorry for the delay, I had a lot of meetings in the wake of our first public launch.

@KastanDay
Copy link
Member

KastanDay commented Sep 1, 2023

@star-nox I pushed that endpoint. You will get response on /onResponseCompletion every time the AI finishes sending a message to the user. It will be the same format as conversation logs on supabase.

Here's the code: CAII-NCSA/uiuc-chat-frontend@190c738

Update: I made it so that it'll push to the flask server for this Pull request. So you should see the responses on Railway, for this PR's deployment.

@KastanDay KastanDay marked this pull request as draft September 6, 2023 22:03
@star-nox
Copy link
Member Author

@KastanDay I am trying to create maps for all the courses right now and I keep getting a read operation timed out error. I got this first when I queried all the data at once and also when I query data course-wise. Have the supabase settings been changed? I was not getting this error when I created the maps before.

@KastanDay
Copy link
Member

did adding the timestamps enable filtering by time? thanks!!

@star-nox
Copy link
Member Author

did adding the timestamps enable filtering by time? thanks!!

nope. the filter still shows up blank.

@star-nox
Copy link
Member Author

did adding the timestamps enable filtering by time? thanks!!

nope. the filter still shows up blank.

Just found one of their maps which has a filter by year - https://atlas.nomic.ai/map/neurips. They have uploaded year in their metadata, same as us. I am browsing the docs again to check if there is any attribute i need to set.

@star-nox
Copy link
Member Author

star-nox commented Sep 13, 2023

So close, but still facing error! I am uploading datetime objects instead of strings.
Found a release note which mentions datetime validation: https://docs.nomic.ai/release_notes.html#v110
image

Update: Found this on the Nomic discord. This is not working for us though.
image

@star-nox
Copy link
Member Author

Another update: added a random number field to check filtering and that works.
image
image
image

@star-nox star-nox marked this pull request as ready for review September 15, 2023 18:44
@star-nox star-nox requested a review from KastanDay September 15, 2023 18:44
@KastanDay
Copy link
Member

@star-nox note in adb1b50 you have some setting that's adding a whitespace character ( ) to every empty line. Please figure out how to change your settings so that doesn't happen, because it's causing your commits to be super messy.

I resolved this using git checkout origin/main <filename> to revert individual files to their status on the main branch.

@KastanDay
Copy link
Member

KastanDay commented Sep 15, 2023

Or please just add yapf to your vscode config using the config settings we have in our .github/workflows folder.

Copy link
Member

@KastanDay KastanDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything is good to go!

@KastanDay KastanDay merged commit 520444a into main Sep 15, 2023
1 check passed
@KastanDay KastanDay deleted the nomic-viz branch September 15, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants