Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ingest file handling for maintainability #73

Merged
merged 7 commits into from
Sep 15, 2023
Merged

Refactor ingest file handling for maintainability #73

merged 7 commits into from
Sep 15, 2023

Conversation

jkmin3
Copy link
Member

@jkmin3 jkmin3 commented Aug 31, 2023

Pull request to see on railway.

@lintrule-review
Copy link

You need to setup a payment method to use Lintrule

You can fix that by putting in a card here.

@railway-app
Copy link

railway-app bot commented Aug 31, 2023 •
edited
Loading

This PR is being deployed to Railway 🚅

flask: ◻️ REMOVED

@KastanDay KastanDay marked this pull request as draft September 6, 2023 22:03
@jkmin3 jkmin3 marked this pull request as ready for review September 11, 2023 19:15
@jkmin3 jkmin3 requested a review from KastanDay September 11, 2023 19:21
KastanDay
KastanDay requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@KastanDay KastanDay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add mime type == text (or whatever the syntax is), and ingest that with the ingest_single_txt function (ensure no changes are needed there).
Thanks! That should support ALLLLL text files.

@KastanDay KastanDay changed the title check if it is a github repo Refactor ingest file handling for maintainability Sep 11, 2023
jkmin3
jkmin3 commented Sep 13, 2023
View reviewed changes
Copy link
Member Author

@jkmin3 jkmin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented the category checking if a file is a text file and makes sure that it isn't one of the files we already have ingest functions for.

@jkmin3 jkmin3 requested a review from KastanDay September 13, 2023 19:02
KastanDay
KastanDay approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@KastanDay KastanDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me.

@KastanDay KastanDay merged commit 241f819 into main Sep 15, 2023
1 check passed
@KastanDay KastanDay deleted the refactor_file_handling branch September 15, 2023 23:09
@KastanDay KastanDay mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KastanDay KastanDay KastanDay approved these changes

Assignees

@jkmin3 jkmin3

Labels
None yet
Projects
UIUC.chat Development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkmin3 @KastanDay