-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fvcom fabm v5 dev #15
Open
riquitorres
wants to merge
333
commits into
UK-FVCOM-Usergroup:FVCOM
Choose a base branch
from
riquitorres:FVCOM-FABM_v5_dev
base: FVCOM
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fvcom fabm v5 dev #15
riquitorres
wants to merge
333
commits into
UK-FVCOM-Usergroup:FVCOM
from
riquitorres:FVCOM-FABM_v5_dev
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e adjusting values.
…. Moved associated variables to mod_fabm_data to make them available outside mod_fabm_3D in anticipation of restricting nesting inputs to only advectable variables
…mended Sediment conversion from g/l to mg/m3 in mod_fabm_3D.F
…ding original sediment namelist
… code -- I had already added it for CSTMS
…rom FVCOM version 4.3.
…Great Lakes (from version 4.3).
…on-hydrostatic runs from version 4.3.
…tructured grid (must be ordered clockwise). If a grid fails this check, the model will not run.
…nto FVCOM-FABM_v5_dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request
help wanted
Extra attention is needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My updates so far. Note that FVCOMv5 from UMASSD repo doesn't work in LakeErie setup and nor does this repo current commit. At least it compiles and runs for multiple options so it might be worth checking in other domains. i will keep updating as I test different options