Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect edge display in RVIZ when tracking cloth #47

Closed
3 tasks done
dcolli23 opened this issue Mar 27, 2023 · 3 comments
Closed
3 tasks done

Incorrect edge display in RVIZ when tracking cloth #47

dcolli23 opened this issue Mar 27, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@dcolli23
Copy link
Contributor

dcolli23 commented Mar 27, 2023

Description

When displaying cloth tracking in RVIZ, the edge markers are constructed using the rope edge function. Instead, the markers should be constructed from the tracked configuration's edges like in 953cebf. This was fixed in another branch but the changes were never pulled into the main branch.

This issue was brought to my attention by Chen Li of Tsinghua University.

To Do:

  • Determine if I should pull in the TrackingMap changes
    • If I do, create a PR from 953cebf
    • Add other commits in tree to fix RVIZ visualization.
  • If not, pull only relevant RVIZ changes from the commit above
    • Pull any tests that are necessary.
    • Adapt edge visualization function to only work with one template on master
@dcolli23 dcolli23 added the bug Something isn't working label Mar 27, 2023
@dcolli23 dcolli23 self-assigned this Mar 27, 2023
dcolli23 added a commit that referenced this issue Mar 27, 2023
- Fixes edge visualization in RVIZ to actually respect the edges
specfied in the template instead of just going off of point order.
@dcolli23
Copy link
Contributor Author

dcolli23 commented Mar 27, 2023

The pull request mentioned above should resolve this issue. I'll merge to master soon. If you can verify that the code in the pull request works on your machine, then I'll merge it to master. Thanks!

@lichenTHU
Copy link

It works well and thanks a lot.
2023-03-28 15-42-12 的屏幕截图

@dcolli23
Copy link
Contributor Author

Fantastic! I'm happy things are working for you now. I'm going to close this issue but I'll keep the pull request (#50) open until someone in the lab can review the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants