Add Tracking Map, Fix cloth edge visualization #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# High-Level Description
Adds the ability for CDCPD to run on multiple deformable object configurations by storing a map of configurations by unique ID (ID unique to each deformable object configuration). This isn't particularly important now but opens the possibility for tracking multiple templates in the future.
This does NOT implement multiple template tracking in the sense of:
- Learning separate LLE weights for separate templates given different initial template states.
- Separating multiple deformable object configurations in the CPD step, meaning that the masked points that belong to another template still impact the CPD score of another, separate deformable object configuration.
- Using masked point association history to disambiguate multi-template (non-instance) segmentation, meaning that if CDCPD receives a mask indicating there are two deformable objects in the segmentation that are interacting, there's no way to tell them apart in the tracking's use of the segmented mask.
## Key Changes
- Adds a std::map to keep track of deformable object configurations (how tracked templates are stored) by unique IDs.
- Changes max segment length to be per edge so that edges can have different maximum lengths.
- Something of this flavor is necessary to specify max edge lengths based on each template's (potentially different) edge lengths compared to any other template's edge lengths.
- Though, it's up for debate as to whether this is the best way to handle this.
- Updates the RVIZ edge visualization to only connect tracked points that belong to the same template.
- Accomplishes this by publishing a MarkerArray message instead of a single Marker message.
- TODO: Connect points based on the edge list. This would make the visualization respect the actual edges and thus correctly visualize cloth.
## Miscellaneous Changes
- Formats CDCPD and Optimizer function signatures as they could have been considered hard to read.
- Simply renames the CDCPD class "tolerance" member to "tolerance_cpd" as the former is ambiguous as to what tolerance we're specifying.
- Adds the Stopwatch class which is a super useful context manager that automatically times a code block's runtime duration and outputs to the given logger (by passing in the logger's name).
- Makes the vertices, points, and edges of the DeformableObjectTracking class private and provides getters/setters for these. Should prevent people from making changes that will shoot them in the foot later.
- Adds testing of ConnectivityGraph in DeformableObjectTracking's tests. Not ideal but at least it has some tests.
- When a non-square cloth was tracked, not all edges were connected. This was due to using the number of points in the length direction for the width direction.
- Fixes edge visualization in RVIZ to actually respect the edges specfied in the template instead of just going off of point order.
- Cleans up some compiler warnings introduced in earlier commits
This was referenced Mar 28, 2023
|
This really needs to be broken up into multiple PRs. +1,113/-342 lines of code means it's basically unreviewable in its current state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large PR but it breaks down to adding the tracking map (see #48) and fixing the RVIZ edge visualization for cloth (#47).