fix: replace reach tabs lib with radix tabs lib #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ryanwolhuter <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
daywiss
approved these changes
Dec 2, 2022
ryanwolhuter
deleted the
ryan/uma-800-vote-history-donut-chart-should-be
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reach UI was the go-to accessible react component library for the last several years. Unfortunately, it is no longer actively maintained.
It's not critical that we replace all our dependencies on their components right away, but I've been taking the opportunity to swap out reach ui for alternatives when I encounter bugs in those components (like in the
Panelcomponent for example).In this case, the
Tabsused in the panel for the vote results and vote details had an issue where it would setcursor: pointeron all of its children even though those children were not interactive — hence the bug reported where the chart shows a hand cursor when it is not interactive.I do intend to add interactivity in the future, but for now I just wanted to disable the pointer cursor. Reach UI does not allow this unfortunately, and so I have replaced that Tabs component with one from my new preferred accessible UI library radix-ui.