Skip to content

fix(frontend): fix same version validation in change-mod-loader modal #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UNIkeEN merged 1 commit into from
Jan 7, 2026
Merged

fix(frontend): fix same version validation in change-mod-loader modal #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/loader-selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const LoaderSelector: React.FC<LoaderSelectorProps> = ({
setSelectedId(selectedModLoader.version);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
}, [selectedModLoader.loaderType]);
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useEffect dependency array is incomplete. The effect uses selectedOptiFine, selectedOptiFine.filename, and selectedModLoader.version, but only depends on selectedModLoader.loaderType.

This means when selectedModLoader.version or selectedOptiFine changes, the local state (selectedId and selectedType) won't be updated to reflect these changes. This could lead to UI inconsistencies where the displayed selection doesn't match the actual selected values.

Consider adding all used dependencies: [selectedModLoader.loaderType, selectedModLoader.version, selectedOptiFine]

Copilot uses AI. Check for mistakes.

function isModLoaderResourceInfo(
version: ModLoaderResourceInfo | OptiFineResourceInfo
Expand Down
29 changes: 14 additions & 15 deletions src/components/modals/change-mod-loader-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const ChangeModLoaderModal: React.FC<ChangeModLoaderModalProps> = ({

const isSameAsCurrent =
selectedModLoader.loaderType === currentModLoader.loaderType &&
selectedModLoader.version ===
parseModLoaderVersion(selectedModLoader.version) ===
parseModLoaderVersion(currentModLoader.version);

return (
Expand Down Expand Up @@ -187,7 +187,7 @@ export const ChangeModLoaderModal: React.FC<ChangeModLoaderModalProps> = ({
}
description={
<Text fontSize="xs" color="gray.500">
{selectedModLoader.version}
{parseModLoaderVersion(selectedModLoader.version)}
</Text>
}
/>
Expand All @@ -196,19 +196,18 @@ export const ChangeModLoaderModal: React.FC<ChangeModLoaderModalProps> = ({
</Flex>
)}
<ModalBody>
{summary?.version &&
selectedModLoader.loaderType !== ModLoaderType.Unknown && (
<LoaderSelector
selectedGameVersion={{
id: summary.version,
gameType: "release",
releaseTime: new Date().toISOString(),
url: "",
}}
selectedModLoader={selectedModLoader}
onSelectModLoader={setSelectedModLoader}
/>
)}
{summary?.version && (
<LoaderSelector
selectedGameVersion={{
id: summary.version,
gameType: "release",
releaseTime: new Date().toISOString(),
url: "",
}}
selectedModLoader={selectedModLoader}
onSelectModLoader={setSelectedModLoader}
/>
)}
</ModalBody>
<ModalFooter>
{selectedModLoader.loaderType === ModLoaderType.Fabric && (
Expand Down
Loading