-
Notifications
You must be signed in to change notification settings - Fork 51
fix(Tauri): fix capabilities and asset protocol configs #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,10 +21,16 @@ | |
| "path": "**" | ||
| }, | ||
| { | ||
| "path": "**/.minecraft" | ||
| "path": "**/.*" | ||
| }, | ||
| { | ||
| "path": "**/.minecraft/**" | ||
| "path": "**/.*/**" | ||
| }, | ||
| { | ||
| "path": "**/.*/**/.*" | ||
| }, | ||
| { | ||
| "path": "**/.*/**/.*/**" | ||
| } | ||
|
Comment on lines
+24
to
34
|
||
| ] | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -53,7 +53,8 @@ | |||||||
| "enable": true, | ||||||||
| "scope": [ | ||||||||
| "**", | ||||||||
|
||||||||
| "**", | |
| "**", | |
| "**/.*", |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The asset protocol scope has been changed from specifically allowing .minecraft directories to broadly allowing ALL hidden directories and files across the filesystem. This significantly widens the security scope beyond what appears necessary.
The patterns **/.*/** and **/.*/**/.*/** will match any hidden directory (starting with a dot) at any filesystem level. This means the application can now serve assets from sensitive directories like ~/.ssh, ~/.aws, ~/.config, etc.
Consider using more specific patterns that only match the required paths. If the issue is that .minecraft needs to be accessed at different filesystem levels, use **/.minecraft/** instead. If other specific hidden directories are needed, list them explicitly rather than using a broad wildcard pattern.
| "**/.*/**", | |
| "**/.*/**/.*/**" | |
| "**/.minecraft/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern
**/.*/**/.*appears to be attempting to match hidden files within hidden directories, but this pattern may not work as intended. In glob patterns,**/matches zero or more directories, so**/.*/**/.*could match paths likedir/.hidden/filebut the meaning is unclear.If the intention is to match nested hidden directories like
.minecraft/.hidden_subdir, consider clarifying the requirement and testing whether this pattern actually achieves it. The pattern might need to be**/.*/.*/, or multiple specific patterns may be needed depending on the actual directory structures being accessed.