Skip to content

Conversation

@baiyuansjtu
Copy link
Collaborator

…ide others' arrow

Checklist

  • Changes have been tested locally and work as expected.
  • All tests in workflows pass successfully.
  • Documentation has been updated if necessary.
  • Code formatting and commit messages align with the project's conventions.
  • Comments have been added for any complex logic or functionality if possible.

This PR is a ..

  • 🆕 New feature
  • 🐞 Bug fix
  • 🛠 Refactoring
  • ⚡️ Performance improvement
  • 🌐 Internationalization
  • 📄 Documentation improvement
  • 🎨 Code style optimization
  • ❓ Other (Please specify below)

Related Issues

Description

  • Please insert your description here and provide info about the "what" this PR is solving.

Additional Context

  • Add any other relevant information or screenshots here.

disabled={loading}
onClick={() => onTypeSelect?.(type)}
/>
{displayMode === "selector" && expandedType && !isSelected ? null : (
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥条件渲染

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是控制是否显示箭头/x吗

selectedModLoader,
onSelectModLoader,
expandedLoaderType,
onExpandLoaderType,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个参数我之前脑测感觉没必要加啊

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果不是外部传入的情况下会出现进入step2时会记录之前选择的selectedModLoader,却没有记录之前的expandedLoaderType,导致虽然内容有展开但是所有的modloadercard都有箭头

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没事了脑子没转过来想到怎么写了

@baiyuansjtu baiyuansjtu requested a review from UNIkeEN July 27, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 选择安装 fabric 之后应该阻止点击 forge

2 participants