Fix node options (#2034)

fix: read options directly from DB

closes #2032

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 **Implemented enhancements:**
 
+- Users can share virtual machines [\#2021]
+- Virtual networks management [\#1984]
+- GPU Mediated devices [\#1955]
+- Allow remove users via GUI [\#2023]
+
 **Bugfixes**
 
 **Refactors**

lib/Ravada/WebSocket.pm

@@ -345,12 +345,34 @@ sub _get_node_info($rvd, $args) {
 
     return {} if!$user->is_admin;
 
-    my $node = Ravada::VM->open(id => $id_node, readonly => 1);
-    $node->_data('hostname');
-    $node->{_data}->{is_local} = $node->is_local;
-    $node->{_data}->{has_bases} = scalar($node->list_bases);
-    return $node->{_data};
+    my $sth = $rvd->_dbh->prepare("SELECT * FROM vms WHERE id=?");
+    $sth->execute($id_node);
+    my $data = $sth->fetchrow_hashref;
+    $data->{is_local}=0;
+    $data->{is_local}=1 if $data->{hostname} eq 'localhost'
+        || $data->{hostname} eq '127.0.0,1'
+        || !$data->{hostname};
 
+    $data->{bases}=_list_bases_node($rvd, $data->{id});
+
+    return $data;
+}
+
+sub _list_bases_node($rvd, $id_node) {
+    my $sth = $rvd->_dbh->prepare(
+        "SELECT d.id FROM domains d,bases_vm bv"
+        ." WHERE d.is_base=1"
+        ."  AND d.id = bv.id_domain "
+        ."  AND bv.id_vm=?"
+        ."  AND bv.enabled=1"
+    );
+    my @bases;
+    $sth->execute($id_node);
+    while ( my ($id_domain) = $sth->fetchrow ) {
+        push @bases,($id_domain);
+    }
+    $sth->finish;
+    return \@bases;
 }
 
 sub _list_recent_requests($rvd, $seconds) {

t/mojo/20_ws.t

@@ -346,6 +346,36 @@ sub test_remove_booking_entry_non_admin($t, $id) {
 
 }
 
+sub test_node_info($vm_name) {
+    my $sth = connector->dbh->prepare("SELECT * FROM vms WHERE vm_type=?");
+    $sth->execute($vm_name);
+
+    my $user = create_user(new_domain_name(), $$);
+
+    while ( my $node = $sth->fetchrow_hashref) {
+        my $ws_args = {
+            channel => '/'.$node->{id}
+            ,login => user_admin->name
+        };
+
+        my $node_info = Ravada::WebSocket::_get_node_info
+                            (rvd_front(), $ws_args);
+        if ($node->{hostname} =~ /localhost|127.0.0.1/) {
+            is($node_info->{is_local},1);
+        } else {
+            is($node_info->{is_local},0);
+        }
+
+        $ws_args->{login} = $user->name;
+
+        $node_info = Ravada::WebSocket::_get_node_info
+                            (rvd_front(), $ws_args);
+
+        is_deeply($node_info,{});
+    }
+
+}
+
 ########################################################################################
 
 init('/etc/ravada.conf',0);
@@ -379,6 +409,8 @@ for my $vm_name ( @{rvd_front->list_vm_types} ) {
 
     diag("Testing Web Services in $vm_name");
 
+    test_node_info($vm_name);
+
     mojo_login($t, $USERNAME, $PASSWORD);
     test_bookings($t);
     my @bases = _create_bases($t, $vm_name);