Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mill build system #154

Closed
wants to merge 15 commits into from
Closed

Mill build system #154

wants to merge 15 commits into from

Conversation

ailrst
Copy link
Contributor

@ailrst ailrst commented Jan 12, 2024

(merged into staging)

Setup the project and tests with mill build system

It seems slightly faster and the command system is much easier to use than SBTs so we could hopefully migrate some of the ad-hoc scripts to the build config eventually

This doesn't remove SBT yet they both seem to coincide ok but we should drop sbt at some point.

@utting
Copy link
Contributor

utting commented Jan 16, 2024

Can you please add a .mill_version file so that we all use the same version?
On MacOS 14.2.1 I get this deprecated warning when using mill 0.11.6 (latest):
[warn] /Users/uqmuttin/git/basil/bil-to-boogie-translator/antlr.sc:12:28: type Sources in package define is deprecated (since Mill after 0.11.0-M8): Use mill.define.Target instead.
[warn] def antlrGrammarSources: Sources
[warn] ^

And then it does not build the antlr sources, so fails to compile at: import Parser.*
How does the import $file.antlr in build.sc work?

@ailrst
Copy link
Contributor Author

ailrst commented Jan 16, 2024

I'm using the same mill version but the config for the antlr sources was wrong. I added the mill-version file.

@utting
Copy link
Contributor

utting commented Jan 16, 2024

Works nicely now thanks :-)
(I renamed .mill_version to .mill-version and committed that).
I can compile, run, and the secret_write output goes through Boogie successfully as usual.

Can you please add a couple of sentences to readme.md to tell people how to use mill?

And maybe we should install and commit the ./mill bootstrap script (I used https://github.com/lefou/millw) so that everyone can easily use mill? There is a windows millw.bat there too.

I cannot see any mill plugins for IntelliJ, but personally I'm happy to run ./mill from the command line. What IDE support do you think others might want?

@ailrst
Copy link
Contributor Author

ailrst commented Jan 17, 2024

I mainly use intellij and Mill is supposed to have build server protocol support and intellij project generation, https://mill-build.com/mill/Installation_IDE_Support.html#_intellij_idea_support I want to at least check that connecting the debugger in intellij still works. I don't tend to use VSCode, I'm not sure what integration to expect there.

@ailrst ailrst marked this pull request as ready for review February 1, 2024 06:01
@ailrst ailrst requested a review from l-kent February 8, 2024 01:49
@ailrst ailrst closed this Mar 1, 2024
@ailrst ailrst deleted the mill branch March 1, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants