Fix issue with memory coalescing #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailrst
requested changes
Jun 24, 2024
| // Combine the byte constants into a 64-bit value | ||
| val sum: BigInt = | ||
| (0 until 8).foldLeft(BigInt(0))((x, y) => x + (s.bytes(b + y).value * (BigInt(2).pow(y * 8)))) | ||
| // section is a multiple of 64-bits and appropriately aligned |
There was a problem hiding this comment.
This doesn't seem accurate? It will coalesce any internal 64-bit bit multiple aligned subsection and concatenate the unaligned prefix and suffix.
| // Section that is safe to convert to 64-bit values | ||
| val section = for (b <- aligned until alignedEnd by 8) yield { | ||
| // Combine the byte constants into a 64-bit value | ||
| val sum: BigInt = |
There was a problem hiding this comment.
This is a concat not really a sum although it uses sums
There was a problem hiding this comment.
This name was just taken from the original implementation
| val alignedEnd = s.bytes.size - alignedSizeMultiple | ||
|
|
||
| // Section that is safe to convert to 64-bit values | ||
| val section = for (b <- aligned until alignedEnd by 8) yield { |
There was a problem hiding this comment.
Should this be alignedStart until alignedEnd by 8?
Would be good to distinguish alignedStart = address, and alignedEnd = region index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
I have an idea for a more sophisticated fix too but it will take more effort so this will work for the time being.