Sprint 12 Release #133

shekarpendem · 2018-04-04T00:09:14Z

This release PR includes the following stories completed in Sprint 12:

As a user I would like the images from the uswds to originate from the uswds dependency empowerai/fs-permit-platform#125
As an FS admin I would like to have an easy way of noticing that a report has been generated after I click the button. empowerai/fs-permit-platform#555
As a user I want the content to use consistent terminology and have a consistent style and tone throughout the site. empowerai/fs-permit-platform#556
As a user I would like to clearly see the side nav menu and breadcrumbs when I land on a Forest page. empowerai/fs-permit-platform#564
As a user I want the style of primary CTA buttons to be consistent throughout the site so that I don't get confused about what UI elements are actionable or what actions I am supposed to take. empowerai/fs-permit-platform#571
As a user, I would like to know where I am at any given point in the permit purchase process. empowerai/fs-permit-platform#587
As a user I want the frontend code to be maintainable so that I can utilize the site empowerai/fs-permit-platform#590
As an FS admin I would like an easy way (other than the back button) to get back to the FS Admin page after submitting a content change request through the google form, so that I can easily continue to review the site make other changes if I want to. empowerai/fs-permit-platform#597
Admin: On the permits report page, in Chrome and IE with JAWS, the keyboard would only sporadically function correctly with the radio buttons empowerai/fs-permit-platform#604
Admin: On the permits report page, there are multiple navigation regions that all need labels empowerai/fs-permit-platform#606
Admin: Form error validation not spoken to screen reader users, errors not spoken when tabbing to invalid inputs. empowerai/fs-permit-platform#607
Admin: Incorrect usage of aria-labelledby="NaN". empowerai/fs-permit-platform#608
Email: Forest service image alt text is missing the visible text shown in the image. empowerai/fs-permit-platform#613
Email: Data table in email missing row headers <th scope="row"> for the cells in column 1. empowerai/fs-permit-platform#614
SPIKE: As a member of the public when I am taken to some part of the Christmas tree page, I do not want to wait for a whole page reload so that I can get there quickly. empowerai/fs-permit-platform#634
As a member of the public, when I click on "forest or district map" in the How to Plan your trip section I expect to be taken to a map for the Forest I selected without waiting for a page reload wait. empowerai/fs-permit-platform#635
As a user I want the checks done on the code during build and deploy to be documented empowerai/fs-permit-platform#638
As a member of the public about to select a forest on the landing page, I don’t want to be confused by the presence of a city name that is not near me empowerai/fs-permit-platform#640
As a FS admin I want an easy way to visit the Forest page I have made updates to so that I make sure my updates are correctly loaded/transferred. empowerai/fs-permit-platform#641
as a user I want the login gov auth to work properly empowerai/fs-permit-platform#652
As a COR I want the OWASP report in the wiki empowerai/fs-permit-platform#708

* addresses most of the 508 bugs on the sprint

* make role dialog and add label to all alerts

* update map links

508 bugs

* update map links

…nt-12-development

# Conflicts: # frontend/src/app/trees/admin/district-dates/district-dates.component.html # frontend/src/app/trees/admin/season-dates/season-dates.component.html

600 aria dialog not reading icon

635 map links

* clear session and local storage properly * intercept 403 and route to access-denied * add role="presentation" to all tables

* no alt

login issues

change to usa-primary - no alt

UX research and summaries initial load.

change vcap service for login gov

…permit-platform into 125_uswds_images

556 content

…rs to the frontend.

* IE vertical flex issue * lines between images

Sprint 11 map alt txt src

125 uswds images

add error handler to intercept authentication errors and redirect use…

556 fix formatting on home page

* add new images

remove unused dependencies

* remove svg viewbox

non-transparent mt hood maps

* resize label * fix path

556 season dates IE issue

* make alert show in full grid

* use moment not angular date

* use moment not angular date * remove periods from 3 letter month abbreviations

556 cancel alert

IE date formatting

…h 15th

OWASP Report

Sprint 12 development into master

lauraGgit · 2018-04-04T13:57:09Z

wiki/christmas-trees/general-guidelines.md

+
+**Content Maintenance**
+
+Forest administrators can request changes to the content at https://forest-service-trees-staging.app.cloud.gov/admin/christmas-trees/reports .


I think this should be a link to the change request form and not the reports?

@lauraGgit this taken care in sprint-13 final PR

cameronwolf and others added 30 commits March 21, 2018 15:30

Update circle to run for sprint-12 branches

ab95a42

508 bugs

e69129a

* addresses most of the 508 bugs on the sprint

508 bugs

e0ce287

* addresses most of the 508 bugs on the sprint

8 digit number

3f4a571

600 aria dialog not reading icon

bd89574

* make role dialog and add label to all alerts

635 map links

e1a9f81

* update map links

Merge pull request #649 from nciinc/508_bugs

02f4fd5

508 bugs

635 map links

98f099b

* update map links

Merge remote-tracking branch 'origin/sprint-12-development' into spri…

3e32e68

…nt-12-development

Merge branch 'sprint-12-development' into 600_aria_dialog

1dd15dd

# Conflicts: # frontend/src/app/trees/admin/district-dates/district-dates.component.html # frontend/src/app/trees/admin/season-dates/season-dates.component.html

change to role = alert

aaa1de3

Merge pull request #650 from nciinc/600_aria_dialog

b9ba860

600 aria dialog not reading icon

Merge pull request #651 from nciinc/635_map_links

366968d

635 map links

login issues

2eab34b

* clear session and local storage properly * intercept 403 and route to access-denied * add role="presentation" to all tables

add title to permit rules html attachment

fd8af77

add title to permit rules html attachment

46157a8

add dept of ag

b0d65cb

hide th in email

2044de6

fix spec

99b04b0

add aria-labelledby to forest radios on report

0f62906

change to usa-primary - no alt

6bc686e

* no alt

Merge pull request #654 from nciinc/auth_login_403_issue

773a553

login issues

Merge pull request #655 from nciinc/571_update_buttons

558d0fd

change to usa-primary - no alt

change vcap service for login gov

ee525c0

UX research and summaries initial load.

f2c8aa7

Removed unexpected directories

6b42dac

Merge pull request #664 from nciinc/sprint-12-ux-wiki

0e82954

UX research and summaries initial load.

Merge pull request #663 from nciinc/652_login_gov_vcap

bee001a

change vcap service for login gov

change Host in login basic auth headers

45809a2

parse login.gov hostname

d198507

shekarpendem and others added 28 commits April 2, 2018 13:26

Merge branch 'sprint-12-development' of https://github.com/nciinc/fs-…

2e4bfc7

…permit-platform into 125_uswds_images

Merge pull request #695 from nciinc/556_content

54d9924

556 content

add error handler to intercept authentication errors and redirect use…

5be3351

…rs to the frontend.

Merge branch 'sprint-12-development' into 125_uswds_images

b6b2886

556 fix formatting on home page

558a469

* IE vertical flex issue * lines between images

Merge pull request #697 from nciinc/sprint-11-map-alt-txt-src

f4d4027

Sprint 11 map alt txt src

Merge pull request #699 from nciinc/125_uswds_images

519def9

125 uswds images

Merge pull request #700 from nciinc/auth_error_handling

1ca993b

add error handler to intercept authentication errors and redirect use…

Merge pull request #701 from nciinc/556_home_formatting

dff2cf7

556 fix formatting on home page

non-transparent mt hood maps

a8fb9ac

* add new images

Merge pull request #702 from nciinc/634_performance

003c382

remove unused dependencies

556 season dates IE issue

03d74e3

* remove svg viewbox

Merge pull request #703 from nciinc/634_thumbnails

e1c0d6b

non-transparent mt hood maps

556 print rules image missing

e77ae71

* resize label * fix path

Merge pull request #704 from nciinc/556_fix_ie_season_dates

2bb9130

556 season dates IE issue

556 cancel alert

7f549a5

* make alert show in full grid

IE date formatting

a2144bf

* use moment not angular date

IE date formatting

dc4c28b

* use moment not angular date * remove periods from 3 letter month abbreviations

Merge pull request #705 from nciinc/556_cancel_alert_issue

ca084ae

556 cancel alert

lint

36b0ebf

specs

e8c9d5e

Merge branch 'sprint-12-development' into IE_date_formatting

ef023f2

specs

b8c7ea4

specs

0dad83b

Merge pull request #706 from nciinc/IE_date_formatting

372fa29

IE date formatting

Added report to wiki on the results of the OWASP ZAP scan run on Marc…

a560f29

…h 15th

Merge pull request #709 from nciinc/708_scan

6e332cf

OWASP Report

Merge pull request #710 from nciinc/sprint-12-development

98358df

Sprint 12 development into master

lauraGgit reviewed Apr 4, 2018

View reviewed changes

lauraGgit merged commit 34ce702 into USDAForestService:dev Apr 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sprint 12 Release #133

Sprint 12 Release #133

shekarpendem commented Apr 4, 2018

lauraGgit Apr 4, 2018

shekarpendem Apr 9, 2018


		Content Maintenance

		Forest administrators can request changes to the content at https://forest-service-trees-staging.app.cloud.gov/admin/christmas-trees/reports .

Sprint 12 Release #133

Sprint 12 Release #133

Conversation

shekarpendem commented Apr 4, 2018

lauraGgit Apr 4, 2018

Choose a reason for hiding this comment

shekarpendem Apr 9, 2018

Choose a reason for hiding this comment