Py open sci review #56

jbousquin · 2024-04-01T16:31:15Z

Start to address Editor review

Fix typo (readme.md): l7 on package name

Fix typo (readme.md): double spaces

Edit (general): new line at each full stop in a markdown paragraph.

fix typo (contributing.rst): double spaces

Edit (general): adding a new line at each full stop in a rst paragraph.

Edit (general): add a new line at each full stop in a markdown or rst paragraph.

… done in the try/except was a bit proactive and gets problematic with keeping the functions in a linear workflow.

jbousquin · 2024-04-10T14:30:49Z

5/388 example tests break docs build (expected with functions moving between modules):

harmonize.add_qa_flag(df, mask, flag) in clean.py
harmonize.df_checks(df, columns=['CharacteristicName']) in clean.py
harmonize.df_checks(df, columns=['ResultMeasureValue']) in clean.py
harmonize.convert_unit_series(quantity_series, unit_series, units = 'mg/l') in convert.py
harmonize.units_dimension(unit_series, units='mg/l') in wq_data.py

… meant to get the updated list, but will need to keep an eye out for additions for the example in docs like this. Especailly right now as there may be updates with WQX 2.0 -> 3.0.

jbousquin · 2024-04-10T22:15:21Z

Removes cyclic modular-level references

* Update README.md Fix typo (readme.md): l7 on package name * Update README.md Fix typo (readme.md): double spaces * Update README.md Edit (general): new line at each full stop in a markdown paragraph. * Update contributing.rst fix typo (contributing.rst): double spaces * Update contributing.rst Edit (general): adding a new line at each full stop in a rst paragraph. * Update example workflow.rst Edit (general): add a new line at each full stop in a markdown or rst paragraph. * Update index.rst Edit (general): add a new line at each full stop in a markdown or rst paragraph. * wet_dry_drop() has become outside the normal workflow, what was being done in the try/except was a bit proactive and gets problematic with keeping the functions in a linear workflow. * from harmonize -> clean: df_checks(). add_qa_flag() * convert_unit_series() moved harmonize -> convert * Import specific functions instead of module * Fix docs examples * Module needs to be imported for example * 'Filter/sieve residue' & 'Yield' now included in this domain. This is meant to get the updated list, but will need to keep an eye out for additions for the example in docs like this. Especailly right now as there may be updates with WQX 2.0 -> 3.0.

jbousquin and others added 11 commits April 1, 2024 11:08

Update README.md

4850fa0

Fix typo (readme.md): l7 on package name

Update README.md

c9df449

Fix typo (readme.md): double spaces

Update README.md

4d79ff5

Edit (general): new line at each full stop in a markdown paragraph.

Update contributing.rst

8e9efd8

fix typo (contributing.rst): double spaces

Update contributing.rst

f86bc05

Edit (general): adding a new line at each full stop in a rst paragraph.

Update example workflow.rst

967fb0f

Edit (general): add a new line at each full stop in a markdown or rst paragraph.

Update index.rst

63d9ae5

Edit (general): add a new line at each full stop in a markdown or rst paragraph.

wet_dry_drop() has become outside the normal workflow, what was being…

8ea1eaa

… done in the try/except was a bit proactive and gets problematic with keeping the functions in a linear workflow.

from harmonize -> clean: df_checks(). add_qa_flag()

275b6ae

convert_unit_series() moved harmonize -> convert

c075dbb

Import specific functions instead of module

2dd1bb5

jbousquin added 3 commits April 10, 2024 09:43

Fix docs examples

5577ed7

Module needs to be imported for example

2309eff

'Filter/sieve residue' & 'Yield' now included in this domain. This is…

65e59a1

… meant to get the updated list, but will need to keep an eye out for additions for the example in docs like this. Especailly right now as there may be updates with WQX 2.0 -> 3.0.

jbousquin merged commit 81448a9 into main Apr 10, 2024
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Py open sci review #56

Py open sci review #56

jbousquin commented Apr 1, 2024

jbousquin commented Apr 10, 2024

jbousquin commented Apr 10, 2024

Py open sci review #56

Py open sci review #56

Conversation

jbousquin commented Apr 1, 2024

jbousquin commented Apr 10, 2024

jbousquin commented Apr 10, 2024