Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py open sci review #61

Merged
merged 35 commits into from
Jul 2, 2024
Merged

Py open sci review #61

merged 35 commits into from
Jul 2, 2024

Commits on Apr 1, 2024

  1. Update README.md

    Fix typo (readme.md): l7 on package name
    jbousquin authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    4850fa0 View commit details
    Browse the repository at this point in the history
  2. Update README.md

    Fix typo (readme.md): double spaces
    jbousquin authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    c9df449 View commit details
    Browse the repository at this point in the history
  3. Update README.md

    Edit (general): new line at each full stop in a markdown paragraph.
    jbousquin authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    4d79ff5 View commit details
    Browse the repository at this point in the history
  4. Update contributing.rst

    fix typo (contributing.rst): double spaces
    jbousquin authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    8e9efd8 View commit details
    Browse the repository at this point in the history
  5. Update contributing.rst

    Edit (general): adding a new line at each full stop in a rst paragraph.
    jbousquin authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    f86bc05 View commit details
    Browse the repository at this point in the history
  6. Update example workflow.rst

    Edit (general): add a new line at each full stop in a markdown or rst paragraph.
    jbousquin authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    967fb0f View commit details
    Browse the repository at this point in the history
  7. Update index.rst

    Edit (general): add a new line at each full stop in a markdown or rst paragraph.
    jbousquin authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    63d9ae5 View commit details
    Browse the repository at this point in the history
  8. wet_dry_drop() has become outside the normal workflow, what was being…

    … done in the try/except was a bit proactive and gets problematic with keeping the functions in a linear workflow.
    jbousquin committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    8ea1eaa View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    275b6ae View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c075dbb View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2dd1bb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Fix docs examples

    jbousquin committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5577ed7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2309eff View commit details
    Browse the repository at this point in the history
  3. 'Filter/sieve residue' & 'Yield' now included in this domain. This is…

    … meant to get the updated list, but will need to keep an eye out for additions for the example in docs like this. Especailly right now as there may be updates with WQX 2.0 -> 3.0.
    jbousquin committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    65e59a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    47b244a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1269896 View commit details
    Browse the repository at this point in the history
  3. remove try/except

    jbousquin committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    75cb733 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    01cae6e View commit details
    Browse the repository at this point in the history
  5. Revert to merge from main

    jbousquin committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d7028ab View commit details
    Browse the repository at this point in the history
  6. Py open sci review (#56) (#59)

    * Update README.md
    
    Fix typo (readme.md): l7 on package name
    
    * Update README.md
    
    Fix typo (readme.md): double spaces
    
    * Update README.md
    
    Edit (general): new line at each full stop in a markdown paragraph.
    
    * Update contributing.rst
    
    fix typo (contributing.rst): double spaces
    
    * Update contributing.rst
    
    Edit (general): adding a new line at each full stop in a rst paragraph.
    
    * Update example workflow.rst
    
    Edit (general): add a new line at each full stop in a markdown or rst paragraph.
    
    * Update index.rst
    
    Edit (general): add a new line at each full stop in a markdown or rst paragraph.
    
    * wet_dry_drop() has become outside the normal workflow, what was being done in the try/except was a bit proactive and gets problematic with keeping the functions in a linear workflow.
    
    * from harmonize -> clean: df_checks(). add_qa_flag()
    
    * convert_unit_series() moved harmonize -> convert
    
    * Import specific functions instead of module
    
    * Fix docs examples
    
    * Module needs to be imported for example
    
    * 'Filter/sieve residue' & 'Yield' now included in this domain. This is meant to get the updated list, but will need to keep an eye out for additions for the example in docs like this. Especailly right now as there may be updates with WQX 2.0 -> 3.0.
    jbousquin authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    851be91 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #60 from USEPA/main

    Update branch to main
    jbousquin authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ffdabd2 View commit details
    Browse the repository at this point in the history
  8. Un-revert added line

    jbousquin committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7314276 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    39d72b2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d8125c4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3544328 View commit details
    Browse the repository at this point in the history
  12. suggestion: replace one dict functions w/ module-level dicts (xy_datu…

    …m, stations_rename, accepted_methods)
    jbousquin committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    20922e1 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7962e1c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b60ecf0 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3729baa View commit details
    Browse the repository at this point in the history
  16. replace one dict functions w/ module-level dicts (unit_basis_dict(out…

    …_col) -> unit_basis_dict[out_col], basis_conversion, stp_dict).
    jbousquin committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7751b1b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6f933f5 View commit details
    Browse the repository at this point in the history
  18. Reverted this line - somehow it was impacting the dataretrieval get f…

    …unctions. Unclear how.
    jbousquin committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    67f6c12 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Update basis.py

    Quick fix
    jbousquin authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e398bb9 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. np.where will coerce x & y to the array dtype. A problem here as it c…

    …onverts np.nan to 'nan'. Reverted it back to the way it was before.
    jbousquin committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3c63d92 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Update basis.py

    Revised dict doc-strings
    jbousquin authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    55cb3cd View commit details
    Browse the repository at this point in the history