62 review edits harmonize pensacolarmd #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to main
…. Open to better options of how to format it as code but not always run it..
Try without renv, fixed typo.
Switch from pip to conda (required of reticulate)
Try setting up env using reticulate instead of conda (since conda-incubator is currently restricted)
Combine install/run so env is not lost
update env name
Combine again without typo
use miniconda_install() (note before I was setting up venv)
install dev package from repo... for tests this should use the currently checked out instead, but just trying to get it working.
Not sure why now it was case sensitive...
pytest already check tests in test.yml, no need to run it a second time here.
Skip unbutu, run all windows (conda)
Trying on ubuntu again
Try on older ubuntu version.
bump action version up (getting warnings)
Drop Ubuntu. Fix where python version is set from the matrix. Conda create with python version from matrix.
Try setting var from matrix using with since it seemed to cut out 3.1* for 3.10.
Try again (hoping it won't truncate python 3.1x this time.
try as sting?
Upload artifact at end to examine rendered html
Based on examples on repo
Only upload on one runner (win 3.11
Updated text to be more accurate with how reticulate can be used
No separators for list to conda
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional text revisions & get the plot working. Seeing warnings but no errors.