This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch nhdv2 attributes from ScienceBase #82
Fetch nhdv2 attributes from ScienceBase #82
Changes from 4 commits
b2860d5
1313d4e
ecb008e
117a029
a3d020e
887bd66
b8e6a13
76f4596
7065cf3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I always default to using function(x) in apply() because I think that it doesn't like it when there are multiple arguments in the given function. Nice to see it works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you describe what is happening here with a couple comments. In particular, why are you using
split()
? (see comment suggestion above).what does
do.call(., 'c')
do ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, thanks! I've added comments to briefly explain what each line is doing within the
p1_vars_of_interest_downloaded_csvs
target. In particular,fetch_nhdv2_attributes_from_sb
returns the file output path for each unique sb_id, sodo.call('c',.)
concatenates those strings into one vector of classchr
.