Skip to content

Conversation

Vitineth
Copy link

Now that everything is nicely in typescript, we can move on to verifying correctness of some core parts like fixtures with unit tests. As I'm going through this I'm finding some bugs as well so will be making a note of them as I go.

  • added isin which is an inverse of the sin animator, this allows us to have opposite pan and tilt effects
  • 150s
    • add bounds checking to rgb values
    • add white support
    • fix shutter index (it was previously a strobe effect proportional but is not random strobe effect which i think was the intention)
    • bounds check intensity
  • profile utilities
    • add better bounds checking to addresses and values, also don't crash the program just warn
    • fix type casting issues
    • don't use falsy for checking entry values as it prevents you setting things to 0
    • add handling for invalid channels (even though it shouldn't happen as its typesafe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant