Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal/migrate to postgres NP-72 #587

Merged
merged 13 commits into from
Jul 14, 2023
Merged

Internal/migrate to postgres NP-72 #587

merged 13 commits into from
Jul 14, 2023

Conversation

akevinge
Copy link
Member

Changes

  • Switched Prisma provider to Postgres
  • Made changes to models, queries as needed. See: Prisma Postgres does not support Postgres composite types
  • SemesterCode is not generated by Prisma anymore and requires manually mapping between SemesterCode and Prisma when querying
  • Add Postgres to CI

@vercel
Copy link

vercel bot commented May 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 4:57am

akevinge
akevinge commented Jun 30, 2023
View reviewed changes
prisma/schema.prisma Outdated Show resolved Hide resolved
prisma/schema.prisma Outdated Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
akevinge
akevinge commented Jun 30, 2023
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
akevinge
akevinge commented Jun 30, 2023
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@akevinge
Copy link
Member Author

Seems like I previously refactored the code pretty poorly to get the new schema to work with the UI. Ideally SemesterCode should not be a thing to avoid having to convert between the db and UI.

@akevinge akevinge marked this pull request as ready for review July 7, 2023 22:49
@akevinge akevinge requested review from a team July 7, 2023 22:49
@akevinge akevinge requested a review from syl15 as a code owner July 7, 2023 22:49
@akevinge akevinge force-pushed the internal/migrate-to-postgres branch from 3feabad to c0e67b2 Compare July 7, 2023 22:56
@akevinge akevinge changed the title Internal/migrate to postgres Internal/migrate to postgres NP-72 Jul 7, 2023
@akevinge akevinge requested a review from jasonappah July 7, 2023 23:02
syl15
syl15 previously approved these changes Jul 8, 2023
View reviewed changes
jasonappah
jasonappah previously approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@jasonappah jasonappah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good and didn't run into any issues when testing locally. I had one question but it's not worth blocking merge over if you want to address it in a later PR.

prisma/seedTemplates.ts Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
@akevinge akevinge mentioned this pull request Jul 8, 2023
Closed
@akevinge akevinge dismissed stale reviews from jasonappah and syl15 via dd2a73f July 10, 2023 21:27
@akevinge akevinge force-pushed the internal/migrate-to-postgres branch from 3127ab1 to dd2a73f Compare July 10, 2023 21:27
@akevinge akevinge mentioned this pull request Jul 11, 2023
Merged
@akevinge akevinge merged commit 473ca92 into develop Jul 14, 2023
5 checks passed
@akevinge akevinge deleted the internal/migrate-to-postgres branch July 14, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonappah jasonappah jasonappah left review comments

@syl15 syl15 syl15 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akevinge @jasonappah @syl15