Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open course dropdown on hover #686

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

akevinge
Copy link
Member

Experimental feature proposed by Laura, one of our users :)

@akevinge akevinge requested a review from a team as a code owner September 26, 2023 18:03
@akevinge akevinge requested review from jasonappah and removed request for jasonappah September 26, 2023 18:03
@github-actions
Copy link

@github-actions
Copy link

Copy link
Contributor

@Peytonbarre Peytonbarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! This might be intentional but I noticed that the dropdown doesn't disappear when the cursor leaves the menu/ellipsis. Do you think this would be worth adding?

image
(Couldn't figure out how to screenshot my cursor lol)

@akevinge
Copy link
Member Author

I like this! This might be intentional but I noticed that the dropdown doesn't disappear when the cursor leaves the menu/ellipsis. Do you think this would be worth adding?

image (Couldn't figure out how to screenshot my cursor lol)

I ran into issues with that because Radix's dropdowns (or dropdowns in general) aren't meant to be triggered by a hover. It's really jank to get it to figure out if the mouse actually left the original spot or not. I just went with this and sent the preview link to Laura (the user that requested). Imo we should just wait to see what she says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants