Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161
Summary
[vss].urlfrom the TOML file as disabled, matchingsample-config.toml.--vss-urlstill overrides the file, while explicit blank CLI values remain validation errors.Why
The resolver previously preserved
url = ""asSome("")and passed it tovalidate_vss_url, causing startup to fail even though the sample config documents an empty value as VSS disabled.Verification
args::tests::empty_vss_url_disables_vssfailed withInvalidVssConfig.vss-feature argument tests: 19 passed.cargo +1.94.0 clippy --locked --lib -- -D warnings: passed.cargo +1.94.0 fmt -- --check: passed.git diff --check: passed.Scope
No network or regtest service was used. The full integration suite was not run because it requires the shared regtest service stack; the change is limited to startup argument resolution and its unit tests.