Skip to content

Fix empty VSS URL handling in config files - #163

Open
Kewe63 wants to merge 1 commit into
UTEXO-Protocol:devfrom
Kewe63:fix/161-empty-vss-url
Open

Kewe63 wants to merge 1 commit into
UTEXO-Protocol:devfrom
Kewe63:fix/161-empty-vss-url

Conversation

@Kewe63

@Kewe63 Kewe63 commented Sep 9, 2026

Copy link
Copy Markdown

Fixes #161

Summary

  • Treat an empty [vss].url from the TOML file as disabled, matching sample-config.toml.
  • Preserve CLI precedence: a valid --vss-url still overrides the file, while explicit blank CLI values remain validation errors.
  • Add regression coverage for the empty-file sentinel and CLI/file precedence matrix.

Why

The resolver previously preserved url = "" as Some("") and passed it to validate_vss_url, causing startup to fail even though the sample config documents an empty value as VSS disabled.

Verification

  • RED before fix: args::tests::empty_vss_url_disables_vss failed with InvalidVssConfig.
  • Default-feature argument tests: 19 passed.
  • vss-feature argument tests: 19 passed.
  • Config tests: 44 passed.
  • cargo +1.94.0 clippy --locked --lib -- -D warnings: passed.
  • cargo +1.94.0 fmt -- --check: passed.
  • git diff --check: passed.

Scope

No network or regtest service was used. The full integration suite was not run because it requires the shared regtest service stack; the change is limited to startup argument resolution and its unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty vss.url is documented as disabled but aborts startup

1 participant