Initial Submission - Manjot #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlou05
reviewed
Sep 20, 2024
Comment on lines
+76
to
+80
| if not self.waypoint_reached: | ||
| # Moves towards the waypoint | ||
| x_dist = self.waypoint.location_x - report.position.location_x | ||
| y_dist = self.waypoint.location_y - report.position.location_y | ||
| command = commands.Command.create_set_relative_destination_command(x_dist, y_dist) |
There was a problem hiding this comment.
Although this works for the simulation, in real life your drone won't be this precise. Please use the acceptnace_radius to account for minor errors in positioning.
Comment on lines
+72
to
+78
| if not self.waypoint_reached: | ||
| # Moves towards the waypoint | ||
| x_dist = self.waypoint.location_x - report.position.location_x | ||
| y_dist = self.waypoint.location_y - report.position.location_y | ||
| command = commands.Command.create_set_relative_destination_command(x_dist, y_dist) | ||
|
|
||
| self.waypoint_reached = True |
There was a problem hiding this comment.
Same here, please use accpetance_radius
Comment on lines
+84
to
+87
| closest_pad = min( | ||
| landing_pad_locations, key=lambda pad: self.get_distance(report.position, pad) | ||
| ) | ||
| print(f"Closest Landpad: {closest_pad.location_x}, {closest_pad.location_y}") |
There was a problem hiding this comment.
This can be moved to the section where you first reach the waypoint. Right now, it recalculates your landing pad continuously (whenever it stops), which is unnecessary.
| # This func returns a tuple, with whether the operation was a sucess (bool) & the bounding box itself | ||
| successful, box = bounding_box.BoundingBox.create(bounds=boxes_cpu[i]) | ||
|
|
||
| if successful: |
There was a problem hiding this comment.
Normally, in statistics, we discard the entire data point (the entire image) if one part of it (the bounding box) is invalid.
(You do not need to change anything here, just something to think about)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.