finished bootcamp #122
Closed
finished bootcamp #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronWang04
reviewed
Nov 8, 2024
| self.start_simulator = False | ||
| elif ( | ||
| report.status == drone_status.DroneStatus.HALTED | ||
| and distance_to_waypoint <= self.acceptance_radius |
There was a problem hiding this comment.
what if the first set_relative_destination_command did not put the drone into the right location? in real life, GPS are analog and have tolerance of error. which is why we have self.acceptance_radius in the first place.
| # ============ | ||
| # ↑ BOOTCAMPERS MODIFY ABOVE THIS COMMENT ↑ | ||
| # ============ | ||
|
|
||
| return command | ||
|
|
||
| def my_sqrt(self, report: drone_report.DroneReport) -> float: |
There was a problem hiding this comment.
function name could probably be more representative of what it does
| self.waypoint.location_x - report.position.location_x, | ||
| self.waypoint.location_y - report.position.location_y, | ||
| ) | ||
| self.start_simulator = False |
There was a problem hiding this comment.
again same issue here with the first set relative destination command not working as intended
Comment on lines
95
to
96
| elif (not self.not_on_pad) and report.status == drone_status.DroneStatus.HALTED: | ||
| command = commands.Command.create_land_command() |
There was a problem hiding this comment.
need to check acceptance radius here again
Comment on lines
+124
to
+125
| if not result: | ||
| return [], image_annotated |
AaronWang04
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.