Final Version #124
Closed
Final Version #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronWang04
approved these changes
Nov 19, 2024
| result, box = bounding_box.BoundingBox.create(boxes_cpu[i]) | ||
| if not result: | ||
| continue | ||
| assert box is not None |
There was a problem hiding this comment.
generally we return an error value (like None) instead of asserting which is then caught at a layer above this (in the same way how if not result we skip it)
Comment on lines
+126
to
+127
| if not result: | ||
| continue |
There was a problem hiding this comment.
the more common practice is to disregard the whole image taken if any of its bounding box has an error (faulty data essentially)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.