Bootcamp Complete?- Muhammad Awan #19
Conversation
| @@ -8,7 +8,6 @@ | |||
| import numpy as np | |||
| import torch | |||
| import ultralytics | |||
|
|
|||
There was a problem hiding this comment.
Nit: One empty line between importing installed modules and importing local modules (remember to not modify anything outside of the area indicated by the comments).
|
|
||
| # Plot the annotated image from the Result object | ||
| # Include the confidence value | ||
| image_annotated = ... | ||
| image_annotated = prediction.plot(conf=0.7) |
There was a problem hiding this comment.
You've already set the confidence above - how do you tell it to use the confidence here?
| # ============ | ||
| # ↑ BOOTCAMPERS MODIFY ABOVE THIS COMMENT ↑ | ||
| # ============ |
There was a problem hiding this comment.
Make sure you're not deleting the comment guards, place your code inside of them. You're allowed to write helper functions outside of the comments.
| if report.status == drone_status.DroneStatus.HALTED and not self.waypoint_found: | ||
| command = commands.Command.create_set_relative_destination_command( | ||
| self.waypoint.location_x, | ||
| self.waypoint.location_y |
There was a problem hiding this comment.
Nit: Add a comma after each argument, including the last argument.
| elif report.status == drone_status.DroneStatus.HALTED and self.landing_pad_found: | ||
| command = commands.Command.create_land_command() |
There was a problem hiding this comment.
While the bootcamp specifies that the drone will always complete its movement, what if this wasn't guaranteed and it could halt on its own at any random time? (You do not need to change anything here, just something to think about).
| elif not within_range and status == drone_status.DroneStatus.HALTED: | ||
| command = commands.Command.create_set_relative_destination_command(way_x, way_y) |
There was a problem hiding this comment.
Change this one to also be relative distance, think about the cases where the drone doesn't start simulation at (0, 0).
No description provided.