Bootcamp - Tao Shen #50
Conversation
| for i in range(num_boxes): | ||
| result, box = bounding_box.BoundingBox.create(boxes_cpu[i]) | ||
| bounding_boxes.append(box) |
There was a problem hiding this comment.
what if the bounding box creation fails (i.e. result is False), do we still want to append the box?
| # Remove this when done | ||
| raise NotImplementedError | ||
|
|
||
| status = report.status |
There was a problem hiding this comment.
let's not reassign variables - use report.status throughout so it's easier to keep track of (and uses less memory)
| elif status == drone_status.DroneStatus.MOVING: | ||
| if self.relative_distance(relative_x_dist, relative_y_dist) < self.acceptance_radius: | ||
| command = commands.Command.create_halt_command() |
There was a problem hiding this comment.
I like this extra check (you don't have to change anything here but combining both if statements with an and would reduce the redundancy)
| status = report.status | ||
| position = report.position |
There was a problem hiding this comment.
same as above, let's not reassign variables - use report.status and report.position throughout so it's easier to keep track of (and uses less memory)
|
|
||
| if self.visited_waypoint: # Travel to nearest landing pad | ||
| if status == drone_status.DroneStatus.HALTED: # If halted, need to first calculate the nearest landing pad | ||
| self.nearest_landing_pad = self.get_nearest_landing_pad(position, landing_pad_locations) |
There was a problem hiding this comment.
avoid calculating this twice (when you reach the landing pad you run this again)
| nearest_landing_pad_distance = current_distance | ||
| return nearest_landing_pad | ||
|
|
||
| def get_relative_location_distance( |
There was a problem hiding this comment.
this is actually the squared distance - let's rename this function to be more descriptive
| locOne: location.Location, | ||
| locTwo: location.Location, |
There was a problem hiding this comment.
we try to use snake_case, not camelCase
No description provided.