first #67
Open
first #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlou05
reviewed
Jun 1, 2024
|
|
||
| # Plot the annotated image from the Result object | ||
| # Include the confidence value | ||
| image_annotated = ... | ||
| image_annotated = prediction.plot() |
There was a problem hiding this comment.
Please include the confidence value in the image (use the conf kwarg)
maxlou05
reviewed
Jun 1, 2024
|
|
||
| for i in range(boxes_cpu.shape[0]): | ||
| results, bbox = bounding_box.BoundingBox.create(boxes_cpu[i]) | ||
| if not results: |
There was a problem hiding this comment.
Normally in statistics, we would discard the entire data point (the whole image and all the bounding boxes) in case one part of it (one bounding box) fails. (You do not need to change anything, just something to think about)
maxlou05
reviewed
Jun 1, 2024
| self.waypoint.location_y - report.position.location_y | ||
| ) | ||
| self.traveled_to_waypoint = True | ||
| elif not self.closest_landing_pad: |
There was a problem hiding this comment.
Using this as a statement to check if you have found the closest landing pad or not can be a little dangerous, in the sense that if there were no landing pads in the list (ie it was empty), you wouldn't know that you had already checked that it was empty. (You do not need to change anything, just something to think about)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.