Dronekit to FlightController Migration - Stale #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzikschenk
commented
Jan 30, 2025
| @@ -43,7 +42,7 @@ def main() -> int: | |||
| try: | |||
| # pylint: disable=invalid-name | |||
| TAKEOFF_ALTITUDE = config["takeoff_altitude"] | |||
| DRONE_TIMEOUT = config["drone_timeout"] | |||
| # DRONE_TIMEOUT = config["drone_timeout"] | |||
There was a problem hiding this comment.
flight_controller doesn't seem to have DRONE_TIMEOUT as a parameter to pass through. Should I make a method to overload upload_commands to include DRONE_TIMEOUT (similar to how Dronekit originally did this)?
Ie: controller.upload_commands(example_commands, DRONE_TIMEOUT)
|
Is the TODO here meant for this PR? |
honzikschenk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves modules that interface with dronekit instance into flightcontroller functions.
Solves: https://app.asana.com/0/75198147526823/1209038150877644/f