[ISSUE-680] Record Zero Length Variables#733
Closed
varndorfer wants to merge 2 commits intoSharedDevelopmentfrom
Closed
[ISSUE-680] Record Zero Length Variables#733varndorfer wants to merge 2 commits intoSharedDevelopmentfrom
varndorfer wants to merge 2 commits intoSharedDevelopmentfrom
Conversation
stiber
reviewed
Nov 21, 2024
Contributor
|
Are any changes needed to |
Contributor
|
So, do we really want to do this? Let's discuss it at a lab meeting; I think there are arguments either way, but maybe not; maybe this was just something different than before. After all, if we don't output a variable, then we know 100% what's in it. OTOH, if we register a variable and it doesn't appear in the output, we can't tell if that means it was empty or if something is broken in the simulator. Hmm... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #680
Description
XML Recorder should produce an empty output for variables with no values. Tested and now the output is as in the below image:
Checklist (Mandatory for new features)
Testing (Mandatory for all changes)
test-medium-connected.xmlPassedtest-large-long.xmlPassed