Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIIR #1

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

RIIR #1

wants to merge 23 commits into from

Conversation

JasonCubed132
Copy link

@JasonCubed132 JasonCubed132 commented Apr 8, 2023

Rewrite dcslauncher in Rust and make use of the PR converting dcspkg to a library.

TODO:

  • This has the dcspkg crate hardcoded as a locally available dependency. This needs to be changed once the PR for dcspkg has been accepted.
  • Also the icons need changing as they're just the default template icons currently.

@Joeyh021
Copy link
Member

Joeyh021 commented Apr 9, 2023

Looks awesome. Tauri is cool.

If there's no config file it panics trying to create one. The error seems to come from the std::fs::write call in config.rs:79

Run cargo clippy and it will show you all the places that errors aren't being handled. Where a function returns a Result, you should log the error message from the error type. The UI should probably indicate if a game fails to install too.

Happy to merge once those two issues (and the few nitpick comments :p) are fixed.

src-tauri/src/main.rs Outdated Show resolved Hide resolved
src-tauri/src/main.rs Outdated Show resolved Hide resolved
src-tauri/src/main.rs Outdated Show resolved Hide resolved
src-tauri/src/main.rs Outdated Show resolved Hide resolved
src-tauri/src/main.rs Outdated Show resolved Hide resolved
@Joeyh021
Copy link
Member

Joeyh021 commented Apr 9, 2023

oh, see also UWCS/dcspkg#18 comments and the associated changes that will be required here for that.

@JasonCubed132
Copy link
Author

I was able to get lazy_static working after being confused by the std::once_cell docs. Hopefully everything works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants