-
Notifications
You must be signed in to change notification settings - Fork 43
Add UxDataset.isel()
#1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add UxDataset.isel()
#1352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this coming in! Regarding the test file:
- How about waiting for PR #1349 to go first, so that we can use the reorg'ed test structure
- There is
test_inheritance.py
that tests forUxDataArray
functions inherited from xarray. Thus, how about creating data array and dataset classes in that one and putting tests here into the dataset class there, rather than creating a new file here?
Thanks for pointing this out, I forgot we had this module. I'll look into merging some of the overlapping tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Minor comment - add documentation UxDataset.isel() method
Thanks! Just added the |
Overview
UxDataset.isel()