Skip to content

Conversation

philipc2
Copy link
Member

@philipc2 philipc2 commented Aug 28, 2025

Overview

  • Introduces a grid-informed implementation of UxDataset.isel()

@philipc2 philipc2 marked this pull request as draft August 28, 2025 16:47
@philipc2 philipc2 self-assigned this Sep 11, 2025
@philipc2 philipc2 changed the title DRAFT: Add UxDataset.isel() Add UxDataset.isel() Sep 11, 2025
@philipc2 philipc2 marked this pull request as ready for review September 11, 2025 19:16
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this coming in! Regarding the test file:

  • How about waiting for PR #1349 to go first, so that we can use the reorg'ed test structure
  • There is test_inheritance.py that tests for UxDataArray functions inherited from xarray. Thus, how about creating data array and dataset classes in that one and putting tests here into the dataset class there, rather than creating a new file here?

@philipc2
Copy link
Member Author

There is test_inheritance.py that tests for UxDataArray functions inherited from xarray. Thus, how about creating data array and dataset classes in that one and putting tests here into the dataset class there, rather than creating a new file here?

Thanks for pointing this out, I forgot we had this module. I'll look into merging some of the overlapping tests

Copy link
Contributor

@rajeeja rajeeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Minor comment - add documentation UxDataset.isel() method

@philipc2
Copy link
Member Author

Good work. Minor comment - add documentation UxDataset.isel() method

Thanks! Just added the isel() methods to our API reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants