Get correct text orientation when base line points are equal and fix #741 #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliotJones
reviewed
Sep 29, 2024
| return TextOrientation.Rotate270; | ||
| } | ||
|
|
||
| throw new Exception($"Could not find TextOrientation for rotation '{rotation}'."); |
There was a problem hiding this comment.
Not sure I follow this change but is there a risk that e.g. 270 throws, should we return Other here instead of throwing? Or 270 is just handled by the 90/-90 cases? Should we check that the value is divisible by 90 cleanly?
There was a problem hiding this comment.
Hi @EliotJones, apologies I completely missed your comment here...
You are 100%, this needs to be handled differently. I will push a fix shorlty
EliotJones
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.