Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null token in DirectObjectFinder, handle null state in SetNamedGraphicsState(), add and test and fix #874 #879

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

BobLd
Copy link
Collaborator

@BobLd BobLd commented Aug 22, 2024

No description provided.

@BobLd BobLd requested a review from EliotJones August 22, 2024 20:38
BobLd added a commit to BobLd/PdfPig.Rendering.Skia that referenced this pull request Aug 22, 2024
@BobLd
Copy link
Collaborator Author

BobLd commented Aug 22, 2024

@EliotJones tests now fixed - good to review
EDIT - finally all good

BobLd added a commit to BobLd/PdfPig.Rendering.Skia that referenced this pull request Aug 23, 2024
BobLd added a commit to BobLd/PdfPig.Rendering.Skia that referenced this pull request Aug 24, 2024
BobLd added a commit to BobLd/PdfPig.Rendering.Skia that referenced this pull request Aug 25, 2024
@jmjohnson05
Copy link

We just waiting for approval on this PR?

@BobLd
Copy link
Collaborator Author

BobLd commented Aug 31, 2024

Yes we are, hopefully this will be reviewed this weekend

BobLd added a commit to BobLd/PdfPig.Rendering.Skia that referenced this pull request Sep 3, 2024
BobLd added a commit to BobLd/PdfPig.Rendering.Skia that referenced this pull request Sep 7, 2024
@BobLd BobLd merged commit 5c168f9 into UglyToad:master Sep 29, 2024
1 check passed
@BobLd BobLd deleted the issue-874 branch September 29, 2024 15:43
BobLd added a commit to BobLd/PdfPig.Rendering.Skia that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants