Fix ByteEncodingCMapTable.CharacterCodeToGlyphIndex() to account for glyph mapping length, add test and fix #881 #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

BobLd merged 1 commit into UglyToad:master from BobLd:issue-881

Sep 29, 2024

Merged

Fix ByteEncodingCMapTable.CharacterCodeToGlyphIndex() to account for glyph mapping length, add test and fix #881 #882

Fix ByteEncodingCMapTable.CharacterCodeToGlyphIndex() to account for …

Annotations

20 warnings

src/UglyToad.PdfPig/PdfFonts/Cmap/CMapUtils.cs#L19

The type 'TKey' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'TKey' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/Util/StackDictionary.cs#L10

The type 'K' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'K' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/Writer/PdfDedupStreamWriter.cs#L74

Nullability of reference types in type of parameter 'x' of 'bool FNVByteComparison.Equals(byte[] x, byte[] y)' doesn't match implicitly implemented member 'bool IEqualityComparer<byte[]>.Equals(byte[]? x, byte[]? y)' (possibly because of nullability attributes).

src/UglyToad.PdfPig/Writer/PdfDedupStreamWriter.cs#L74

Nullability of reference types in type of parameter 'y' of 'bool FNVByteComparison.Equals(byte[] x, byte[] y)' doesn't match implicitly implemented member 'bool IEqualityComparer<byte[]>.Equals(byte[]? x, byte[]? y)' (possibly because of nullability attributes).

src/UglyToad.PdfPig/Writer/Xmp/XmpWriter.cs#L249

Possible null reference argument for parameter 'other' in 'XDocument.XDocument(XDocument other)'.

src/UglyToad.PdfPig/Util/StackDictionary.cs#L10

The type 'K' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'K' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/Util/StackDictionary.cs#L56

The type 'K' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'K' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/Content/OptionalContentGroupElement.cs#L154

Possible null reference argument for parameter 'values' in 'string string.Join(string? separator, IEnumerable<string?> values)'.

src/UglyToad.PdfPig/PdfFonts/Cmap/CMapUtils.cs#L19

The type 'TKey' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'TKey' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/Util/StackDictionary.cs#L10

The type 'K' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'K' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/PdfFonts/Cmap/CMapUtils.cs#L19

The type 'TKey' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'TKey' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/Util/StackDictionary.cs#L10

The type 'K' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'K' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/Writer/PdfDedupStreamWriter.cs#L74

src/UglyToad.PdfPig/Writer/Xmp/XmpWriter.cs#L249

Possible null reference argument for parameter 'other' in 'XDocument.XDocument(XDocument other)'.

src/UglyToad.PdfPig/Content/OptionalContentGroupElement.cs#L154

Possible null reference argument for parameter 'values' in 'string string.Join(string? separator, IEnumerable<string?> values)'.

src/UglyToad.PdfPig/Util/StackDictionary.cs#L10

The type 'K' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'K' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/Util/StackDictionary.cs#L56

The type 'K' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'K' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/PdfFonts/Cmap/CMapUtils.cs#L19

The type 'TKey' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'TKey' doesn't match 'notnull' constraint.

src/UglyToad.PdfPig/Util/StackDictionary.cs#L10

The type 'K' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'K' doesn't match 'notnull' constraint.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ByteEncodingCMapTable.CharacterCodeToGlyphIndex() to account for glyph mapping length, add test and fix #881 #882

Fix ByteEncodingCMapTable.CharacterCodeToGlyphIndex() to account for glyph mapping length, add test and fix #881 #882

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...