feat: 상품 목록 조회 DTO 필드 추가 #55
Conversation
Walkthrough채팅방 응답의 product 타입을 Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as 클라이언트
participant S as ChatRoomService
participant R as CustomChatRoomRepository
participant DB as DB
C->>S: 채팅방 목록 요청
S->>R: getChatRooms(...)
R->>DB: 채팅방 + 상품 조인 쿼리 (프로젝션: ChatRoomProductResponse)
DB-->>R: 조회 결과
R-->>S: ChatRoomResponse(product=ChatRoomProductResponse ...)
S-->>C: 응답 반환
note right of R: product 서브프로젝션이 ChatRoomProductResponse로 변경됨
sequenceDiagram
autonumber
participant C as 클라이언트
participant S as ProductService
participant R as CustomProductRepository
participant DB as DB
C->>S: 상품 목록/검색 요청
S->>R: getAllProducts / searchProducts
R->>DB: product ← user,image LEFT JOIN zzim + COUNT(zzim.id)
DB-->>R: 집계 결과 (이미지 최소값, zzimCount 등)
R-->>S: ProductListResponse(..., zzimCount)
S-->>C: 응답 반환
note right of R: groupBy 및 프로젝션에 zzimCount 추가
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java (1)
65-83: getMyProducts가 새 DTO 생성자와 불일치(7→8 인자)합니다ProductListResponse가 zzimCount를 요구하는데, 여기서는 7개 인자만 투영하고 있어 런타임에서 매핑 실패가 납니다. zzim 조인/집계를 추가해 8번째 인자를 채워주세요.
아래와 같이 수정 제안드립니다.
List<ProductListResponse> content = jpaQueryFactory .select(Projections.constructor(ProductListResponse.class, product.id, product.title, product.price, user.nickname.coalesce(user.name).coalesce(""), user.picture, - image.imageUrl.min(), - product.isSale.not() + image.imageUrl.min(), + product.isSale.not(), + zzim.id.countDistinct() )) .from(product) - .leftJoin(product.images, image).on(image.imageOrder.eq(0L)) + .leftJoin(product.images, image).on(image.imageOrder.eq(0L)) + .leftJoin(zzim).on(zzim.product.id.eq(product.id)) .where(product.user.id.eq(userId)) .groupBy(product.id, product.title, product.price, user.nickname, user.name, user.picture, product.isSale)메서드 상단에 별칭 선언도 추가합니다.
QProduct product = QProduct.product; QImage image = QImage.image; QUser user = QUser.user; + QZzim zzim = QZzim.zzim;src/main/java/com/uhdyl/backend/chat/repository/CustomChatRoomRepositoryImpl.java (1)
56-64: isCompleted 의미 뒤바뀜: qProduct.isSale → qProduct.isSale.not()로 수정 필요ChatRoomProductResponse의 마지막 필드는 isCompleted인데, 현재 qProduct.isSale을 그대로 전달하고 있어 의미가 반대입니다.
다음처럼 수정하세요(판매자 이름 null 대비 coalesce도 함께 권장).
Projections.constructor( ChatRoomProductResponse.class, qProduct.id, qProduct.title, qProduct.price, - qProduct.user.nickname, + qProduct.user.nickname.coalesce(qProduct.user.name).coalesce(""), qProduct.user.picture, mainImageUrl, - qProduct.isSale + qProduct.isSale.not() ),
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/main/java/com/uhdyl/backend/chat/dto/response/ChatRoomResponse.java(3 hunks)src/main/java/com/uhdyl/backend/chat/repository/CustomChatRoomRepositoryImpl.java(2 hunks)src/main/java/com/uhdyl/backend/product/dto/response/ChatRoomProductResponse.java(1 hunks)src/main/java/com/uhdyl/backend/product/dto/response/ProductListResponse.java(1 hunks)src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java(4 hunks)
🧰 Additional context used
🧬 Code graph analysis (5)
src/main/java/com/uhdyl/backend/chat/dto/response/ChatRoomResponse.java (2)
src/main/java/com/uhdyl/backend/chat/domain/ChatRoom.java (1)
Entity(12-43)src/main/java/com/uhdyl/backend/chat/service/ChatRoomService.java (3)
Service(23-102)Transactional(35-64)chatRoomRepository(49-57)
src/main/java/com/uhdyl/backend/chat/repository/CustomChatRoomRepositoryImpl.java (2)
src/main/java/com/uhdyl/backend/chat/repository/ChatRoomRepository.java (1)
ChatRoomRepository(8-11)src/main/java/com/uhdyl/backend/chat/service/ChatRoomService.java (2)
Service(23-102)chatRoomRepository(49-57)
src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java (3)
src/main/java/com/uhdyl/backend/zzim/repository/CustomZzimRepositoryImpl.java (3)
RequiredArgsConstructor(19-97)Override(24-64)Override(66-94)src/main/java/com/uhdyl/backend/zzim/domain/Zzim.java (1)
Entity(11-42)src/main/java/com/uhdyl/backend/zzim/repository/ZzimRepository.java (2)
ZzimRepository(10-16)findByUserAndProduct(13-13)
src/main/java/com/uhdyl/backend/product/dto/response/ProductListResponse.java (2)
src/main/java/com/uhdyl/backend/product/dto/response/MyProductListResponse.java (1)
MyProductListResponse(5-10)src/main/java/com/uhdyl/backend/product/domain/Product.java (1)
Entity(33-106)
src/main/java/com/uhdyl/backend/product/dto/response/ChatRoomProductResponse.java (3)
src/main/java/com/uhdyl/backend/product/dto/response/ProductDetailResponse.java (1)
ProductDetailResponse(5-17)src/main/java/com/uhdyl/backend/chat/domain/ChatRoom.java (1)
Entity(12-43)src/main/java/com/uhdyl/backend/product/dto/response/ProductCreateResponse.java (1)
ProductCreateResponse(5-12)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
src/main/java/com/uhdyl/backend/chat/dto/response/ChatRoomResponse.java (1)
15-16: ChatRoomProductResponse로의 전환 LGTM필드 타입 및 팩토리 메서드 전환이 일관적입니다. 상응하는 리포지토리 투영의 isCompleted 의미만 위 파일 수정과 같이 맞춰주세요.
Also applies to: 24-25
src/main/java/com/uhdyl/backend/product/dto/response/ChatRoomProductResponse.java
Show resolved
Hide resolved
src/main/java/com/uhdyl/backend/product/dto/response/ProductListResponse.java
Show resolved
Hide resolved
src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java
Show resolved
Hide resolved
src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java (3)
74-76: zzim 카운트는 countDistinct로 안전하게현재 조인 구성상 중복은 없어 보이지만, 향후 조인 추가/변경으로 중복 행이 생겨도 안전하도록 distinct 집계를 권장합니다.
- product.isSale.not(), - zzim.id.count() + product.isSale.not(), + zzim.id.countDistinct()
221-223: getAllProducts: zzim 카운트도 countDistinct 권장안전한 집계를 위해 distinct 사용을 권장합니다.
- product.isSale.not(), - zzim.id.count() + product.isSale.not(), + zzim.id.countDistinct()
277-279: searchProducts: zzim 카운트도 countDistinct 권장동일 사유로 distinct 집계를 권장합니다.
- product.isSale.not(), - zzim.id.count() + product.isSale.not(), + zzim.id.countDistinct()
🧹 Nitpick comments (3)
src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java (3)
73-73: imageUrl min/그룹바이 불일치: 일관화 제안getMyProducts는 image.imageUrl.min()을 선택하면서 groupBy에 image.imageUrl을 포함하고 있어 중복된 설정입니다. 다른 메서드와 동일하게 단일 메인이미지를 조인하고 있으므로 min() 없이 imageUrl로 통일하는 편이 단순합니다.
- image.imageUrl.min(), + image.imageUrl,Also applies to: 82-82
72-72: user.picture null 처리 일관성타 메서드들은
user.picture.coalesce("")를 사용합니다. getMyProducts도 동일하게 처리해 응답 일관성을 맞추는 편이 좋습니다.- user.picture, + user.picture.coalesce(""),
229-239: 검색/목록 성능 고려 사항
- where(product.isSale = true) 경로가 핵심이므로 DB에 따라
idx_product_is_sale_created_at같은 복합 인덱스를 고려하세요.- 제목 like 검색은 전방/부분 일치로 인덱스 활용이 제한됩니다. MySQL이면 FULLTEXT(ngram), PostgreSQL이면 trigram(GIN) 인덱스 고려를 추천합니다.
Also applies to: 255-263
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java(6 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java (3)
src/main/java/com/uhdyl/backend/zzim/repository/CustomZzimRepositoryImpl.java (2)
Override(24-64)Override(66-94)src/main/java/com/uhdyl/backend/zzim/domain/Zzim.java (1)
Entity(11-42)src/main/java/com/uhdyl/backend/zzim/repository/ZzimRepository.java (2)
ZzimRepository(10-16)findByUserAndProduct(13-13)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (3)
src/main/java/com/uhdyl/backend/product/repository/CustomProductRepositoryImpl.java (3)
82-82: groupBy에서 zzim.id 제거: 잘 반영됨이제 제품 단위로 정확히 집계됩니다. 페이지네이션/카운트 왜곡 이슈 해소에 동의합니다.
231-231: search/getAll의 groupBy 정정 OK두 쿼리 모두 제품 단위 그룹화로 정리된 점 좋습니다.
Also applies to: 286-286
83-84: GROUP BY 쿼리에서 createdAt 정렬 호환성 확인/보완 필요기본 정렬이 createdAt DESC인데, GROUP BY 쿼리에서 그룹화되지 않은 컬럼으로 ORDER BY 하면 PostgreSQL 및 MySQL(ONLY_FULL_GROUP_BY ON)에서 오류가 납니다. 그룹 컬럼에 createdAt을 포함하거나, 기본 정렬을 product.id DESC(또는 createdAt.max())로 대체하는 방안을 검토해 주세요.
빠른 완화책(그룹 컬럼 추가):
- .groupBy(product.id, product.title, product.price, user.nickname, user.name, user.picture, image.imageUrl, product.isSale) + .groupBy(product.id, product.title, product.price, user.nickname, user.name, user.picture, image.imageUrl, product.isSale, product.createdAt)동일 변경을 getAllProducts와 searchProducts의 groupBy에도 적용해 주세요.
Also applies to: 231-233, 286-287
What is this PR?🔍
Changes💻
ScreenShot📷
Summary by CodeRabbit
New Features
Refactor