Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on Windows and MacOS #132

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Run tests on Windows and MacOS #132

merged 1 commit into from
Dec 23, 2024
+93 −20

Conversation

thschmitt
Copy link
Collaborator

  • Extend the CI workflow to test on Windows and MacOS
  • Add missing Close() calls when opening the temporary test files
  • Fix test with relative paths on different drives. On the Windows GitHub runners the cache directory is on drive C and the current working directory is on drive D which makes the relative path resolution fail.

@thschmitt
Run tests on Windows and MacOS
1327ad0 
- Extend the CI workflow to test on Windows and MacOS
- Add missing Close() calls when opening the temporary test files
- Fix test with relative paths on different drives.
  On the Windows GitHub runners the cache directory is on drive C and
  the current working directory is on drive D which makes the relative
  path resolution fail.
@thschmitt thschmitt merged commit 1315e06 into main Dec 23, 2024
8 checks passed
@thschmitt thschmitt deleted the feature/test-on-windows-macos branch January 16, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radu-iviniciu radu-iviniciu radu-iviniciu approved these changes

@paul-ciobanu paul-ciobanu Awaiting requested review from paul-ciobanu paul-ciobanu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thschmitt @radu-iviniciu