Problem: omni_vfs has some bugs and issues (🚀 omni_vfs 0.1.1) (omnigr…

…es#559)

extensions/omni_vfs/CHANGELOG.md

@@ -0,0 +1,22 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres
+to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [0.1.1] - 2023-04-14
+
+### Fixed
+
+* A potential crash when operating with deleted local FS mounts [#560](https://github.com/omnigres/omnigres/pull/560)
+
+## [0.1.0] - 2023-03-05
+
+Initial release following a few months of iterative development.
+
+[Unreleased]: https://github.com/omnigres/omnigres/commits/next/omni_httpd
+
+[0.1.0]: [https://github.com/omnigres/omnigres/pull/511]
+
+[0.1.1]: [https://github.com/omnigres/omnigres/pull/559]

extensions/omni_vfs/local_fs.c

@@ -127,6 +127,10 @@ static char *get_mount_path(Datum fs_id) {
   if (rc != SPI_OK_SELECT) {
     ereport(ERROR, errmsg("fetching mount failed"), errdetail("%s", SPI_result_code_string(rc)));
   }
+  if (SPI_tuptable->numvals == 0) {
+    ereport(ERROR, errmsg("fetching mount failed"),
+            errdetail("missing information in omni_vfs.local_fs_mounts"));
+  }
 
   TupleDesc tupdesc = SPI_tuptable->tupdesc;
   HeapTuple tuple = SPI_tuptable->vals[0];

extensions/omni_vfs/tests/deleted.yml

@@ -0,0 +1,27 @@
+$schema: "https://raw.githubusercontent.com/omnigres/omnigres/master/pg_yregress/schema.json"
+instance:
+  init:
+  - create extension omni_vfs cascade
+
+# This particular test is a regression test that ensure if between obtaining the `local_fs`
+# and using it, the record of it is gone, we don't crash and properly error out
+
+tests:
+
+- name: create a local filesystem
+  # We save it so we can avoid recreating it to test this regression
+  query: create table fs_info as (select omni_vfs.local_fs('.') as fs)
+  commit: true
+
+- name: destroy the backend information
+  query: delete
+         from omni_vfs.local_fs_mounts
+  commit: true
+
+- name: try accessing the filesystem
+  query: select *
+         from omni_vfs.list((select fs from fs_info), '.')
+  error:
+    severity: ERROR
+    message: fetching mount failed
+    detail: missing information in omni_vfs.local_fs_mounts

extensions/omni_vfs/tests/local_fs.yml

@@ -22,6 +22,8 @@ tests:
     select * from omni_vfs.list(omni_vfs.local_fs('../../../../extensions/omni_vfs/tests'), '')
     order by name
   results:
+  - name: deleted.yml
+    kind: file
   - name: empty
     kind: dir
   - name: local_fs.yml
@@ -46,6 +48,8 @@ tests:
     select * from omni_vfs.list_recursively(omni_vfs.local_fs('../../../../extensions/omni_vfs/tests'), '.')
     order by name
   results:
+  - name: deleted.yml
+    kind: file
   - name: empty
     kind: dir
   - name: empty/.keepme

versions.txt

@@ -16,6 +16,6 @@ omni_txn=0.1.0
 omni_types=0.1.0
 omni_var=0.1.0
 omni_vfs_types_v1=0.1.0
-omni_vfs=0.1.0
+omni_vfs=0.1.1
 omni_web=0.1.0
 omni_xml=0.1.0