Added new underground stone types #150
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unarelith
force-pushed
the
master
branch
4 times, most recently
from
997871c
to
5db8341
Compare
Unarelith
requested changes
Jul 18, 2020
There was a problem hiding this comment.
I can merge this PR if:
- A struct
UndergroundBlockGenDefis created to storeunderground_blocksentries- It should have its own file:
source/common/world/UndergroundBlockGenDef.hpp - It should have the following attributes:
stringID,probability,gen_type
- It should have its own file:
- This struct is loaded from Lua
It's not very difficult, I can help for anything if you have questions.
| @@ -34,6 +34,12 @@ mod:biome { | |||
| precipitation = 0.3 | |||
| }, | |||
|
|
|||
| undergroundBiomeBlocks = { | |||
There was a problem hiding this comment.
Should be named undeground_blocks
| @@ -93,6 +99,9 @@ mod:biome { | |||
| temperature = -0.3, | |||
| precipitation = -0.7 | |||
| }, | |||
|
|
|||
| undergroundBiomeBlocks = { | |||
| }, | |||
There was a problem hiding this comment.
the empty table shouldn't be needed
| @@ -129,6 +138,9 @@ mod:biome { | |||
| precipitation = -1 | |||
| }, | |||
|
|
|||
| undergroundBiomeBlocks = { | |||
| }, | |||
There was a problem hiding this comment.
the empty table shouldn't be needed
| harvest_requirements = 1 | ||
| } | ||
|
|
||
|
|
| @@ -49,6 +49,7 @@ class Biome : public gk::ISerializable { | |||
| void setLabel(const std::string &label) { m_label = label; } | |||
|
|
|||
| const std::vector<double> &getParams() const { return m_params; } | |||
| const std::vector<u16> &getUndergroundBiomeBlocks() const { return m_undergroundBiomeBlocks; } | |||
| @@ -83,6 +85,7 @@ class Biome : public gk::ISerializable { | |||
|
|
|||
| // TODO something to distinguish the worldtype of biome | |||
| std::vector<double> m_params; | |||
| std::vector<u16> m_undergroundBiomeBlocks; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added granite, diorite and andesite generation.