Contributor onboarding + fix dev/e2e port mismatch - #1
Open
unforced wants to merge 1 commit into
Open
Conversation
- CONTRIBUTING.md: prerequisites, the branch+PR workflow, the test gate, and a clear "front-end needs no Cloudflare / here's the scoped-token path when you do" guide for new collaborators - README + CLAUDE.md: point to CONTRIBUTING, note the dev port, refresh the natalengine version (^1.3.0 → ^1.6.0) - vite.config: pin the dev server to 5174 (strictPort). The e2e default and the worker's allowed auth origins already assume 5174, but Vite was silently running on 5173 — so `npm run dev` + `npm run e2e` now work together out of the box. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up the repo for onboarding a new collaborator (frontend-first) and fixes a papercut that would bite them on day one.
What's here
CONTRIBUTING.md(new) — prerequisites (Node 20+, Chrome for e2e), clone→install→dev, the feature-branch + PR workflow, thenpm test+npm run e2egate, and a clear table of what needs Cloudflare vs. what doesn't (frontend = nothing). Includes the scoped-API-token path (Edit Cloudflare Workerstemplate **+ D1: Edit`) for when a contributor needs to deploy the Worker.natalengineversion refreshed^1.3.0 → ^1.6.0.vite.config.js— pin dev server to 5174 (strictPort). The e2e default and the worker's allowed auth origins already assume 5174, but Vite was silently running on 5173, so the documentednpm run dev+npm run e2eflow would have failed for a new contributor. Now it works with zero env vars.Verification
npm run buildcleannpm run dev(now on 5174) +npm run e2e→ all checks pass with noE2E_URLoverrideFirst PR through the new branch + PR workflow we're adopting. 🌱
🤖 Generated with Claude Code