-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add s3 support #1197
base: master
Are you sure you want to change the base?
add s3 support #1197
Conversation
@streamtw This would be amazing to have merged, so private S3 buckets can be used.. |
Thanks for the info and this PR. I don't have a S3 bucket now. But I will sure apply one and test this PR before merging. Cannot garuantee a specific date though. |
Thanks. Seems the temporaryUrl() thing is needed for private S3 buckets. Also, we've been unable to make the thumbnails load from S3 buckets. Might be worth looking at other PRs and issues around S3 at the same time, as it'd be good to get S3 compatibility fully fixed. We are currently facing having to try and move away from this package because we have a large multi-tenant multi-server app which needs to use per-tenant S3 buckets for all stored files. |
@streamtw Did you get anywhere with this? |
Ok this PR which remove those |
(optional) Issue number:
Summary of the change:
I have changed the image URL to use temporary URLs if the selected storage is s3