Open
Conversation
Added avatar Ellipse with ImageBrush Added sender name and timestamp TextBlocks Added zoom ComboBox (100%-1000%) Added layered zoom mode toggle button Added zoom in/out buttons Added "More" button with MenuFlyout Added MenuFlyoutItems: Save as, Share, Open in browser, Copy images, Copy link, Copy attachment ID Added MenuFlyoutSeparator Added InfoBar for success notification Added x:Uid attributes for all localizable elements
Added fields: _isZoomMode, _isPanning, _lastPointerPosition, _messageViewModel, _attachmentId, _currentAttachmentUri, _originalFileName Added methods: EnterZoomMode(), ExitZoomMode(), EnsureZoomEnabled(), UpdateZoomButtonVisual(), UpdateSenderInfo(), UpdateZoomComboBox(), SetZoomLevel(), ShowSuccessBanner() Added event handlers: ZoomModeButton_Click, attachmentImage_DoubleTapped, ZoomIn_Click, ZoomOut_Click, imageScrollViewer_PointerPressed/Moved/Released, ImageScrollViewer_ViewChanged, ZoomComboBox_SelectionChanged/TextSubmitted/LostFocus/KeyDown, SaveAs_Click, Share_Click, OnDataRequested, OpenInBrowser_Click, CopyImages_Click, CopyLink_Click, CopyAttachmentId_Click, ApplyZoomFromText() Enhanced OnNavigatedTo to store attachment metadata and setup sender info Added ResourceLoader for localized strings Added reflection to access private DiscordAttachment fields Added DataTransferManager integration for sharing
Changed ImageEmbed_CornerRadius from 2 to 8 Changed Attachment_CornerRadius from 4 to 8
- Added AttachmentOverlay_ZoomModeButton.[using:Windows.UI.Xaml.Controls]ToolTipService.ToolTip - Added AttachmentOverlay_ZoomInButton.[using:Windows.UI.Xaml.Controls]ToolTipService.ToolTip - Added AttachmentOverlay_ZoomOutButton.[using:Windows.UI.Xaml.Controls]ToolTipService.ToolTip - Added AttachmentOverlay_MoreButton.[using:Windows.UI.Xaml.Controls]ToolTipService.ToolTip - Added AttachmentOverlay_SaveAsMenuItem.Text - Added AttachmentOverlay_ShareMenuItem.Text - Added AttachmentOverlay_OpenInBrowserMenuItem.Text - Added AttachmentOverlay_CopyImagesMenuItem.Text - Added AttachmentOverlay_CopyLinkMenuItem.Text - Added AttachmentOverlay_CopyAttachmentIdMenuItem.Text - Added AttachmentOverlay_SaveSuccessMessage
Collaborator
|
EYO THAT'S HOT, sorry I'm currently out of the country but I'll get on reviewing these as soon as I'm home, once again nice work :) |
Contributor
Author
Haha thanks! No worries at all, enjoy your time abroad and have a safe trip! |
Contributor
Author
|
i found some issue, so i will set it temporarily as draft for now |
…d become too big Added UseFullscreen property - Allows toggling between fullscreen mode and padded mode Added validation - Check for width <= 0 || height <= 0 to prevent invalid sizes
This was following the discord approach. it was to prevent controls from becoming unreadable. Unigram follows a similar method. However, if we want the design to fully respect the theme, we should adopt the Photo app approach though this comes at the cost of reducing the available view area
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the attachment overlay (image viewer) zoom controls, date display, and action menu from latest discord interface. Features:
Tested on: Windows 11 Version 25H2 (OS Build 26220.7523) x64
Preview: