Skip to content

Commit

Permalink
Rewrite groovy tests as junit (#1334)
Browse files Browse the repository at this point in the history
* Rewrite groovy tests as junit

* Rewrite groovy test as junit

* Rewrite groovy test as junit

* Rewrite groovy test as junit

* Rewrite groovy test as junit

* Rewrite groovy test as junit

* Remove groovy tests testing legacy code

* Remove groovy and spock test dependencies
  • Loading branch information
tdrwenski committed Apr 18, 2024
1 parent 3c409dc commit 8021ad0
Show file tree
Hide file tree
Showing 27 changed files with 539 additions and 1,371 deletions.
4 changes: 2 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ Once you are satisfied with your work, there is one last step to complete before

### <a name="#gh-style-guidelines"></a>Follow these Style Guidelines

#### Java, Groovy, and Gradle
We are using the [Google Java Style Guide](https://google.github.io/styleguide/javaguide.html) for Java, Groovy, and Gradle, with these exceptions and augmentations:
#### Java and Gradle
We are using the [Google Java Style Guide](https://google.github.io/styleguide/javaguide.html) for Java and Gradle, with these exceptions and augmentations:

1. The recommended line width is 120, not 100.
Modern screens are much wider than tall, so having wider lines allows more code to fit on a screen.
Expand Down
4 changes: 0 additions & 4 deletions cdm/core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ apply from: "$rootDir/gradle/any/dependencies.gradle"
apply from: "$rootDir/gradle/any/java-library.gradle"
apply from: "$rootDir/gradle/any/protobuf.gradle"

apply plugin: 'groovy' // For Spock tests.

dependencies {
api enforcedPlatform(project(':netcdf-java-platform'))
implementation 'commons-math:commons-math'
Expand All @@ -32,9 +30,7 @@ dependencies {
testImplementation 'com.google.truth:truth'
testImplementation 'commons-io:commons-io'
testImplementation 'junit:junit'
testImplementation 'org.codehaus.groovy:groovy-all' // for Spock.
testImplementation 'org.mockito:mockito-core'
testImplementation 'org.spockframework:spock-core'

testRuntimeOnly 'ch.qos.logback:logback-classic'
}
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 8021ad0

Please sign in to comment.