Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw and handle exception when trying to create a variable with a zero dimension #1083

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

mnlerman
Copy link
Contributor

Addresses /issues/1037

Description of Changes

Warns but does not error out when reading a HDF5 file with zero in the dimensions

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@mnlerman mnlerman added bug Something isn't working iosp: hdf5 hdf5 file format labels Sep 16, 2022
@mnlerman
Copy link
Contributor Author

mnlerman commented Jan 2, 2024

PR opened as a draft because I wasn't able to fully test the fix because we don't have a file to test with (see comment on #1037 requesting test file)

@tdrwenski tdrwenski marked this pull request as ready for review April 12, 2024 18:49
@tdrwenski tdrwenski self-requested a review April 12, 2024 18:50
@tdrwenski tdrwenski merged commit 9b9821b into Unidata:maint-5.x Apr 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iosp: hdf5 hdf5 file format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants