Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Grib2 template 4.60 #1164

Closed
wants to merge 2 commits into from
Closed

Add Grib2 template 4.60 #1164

wants to merge 2 commits into from

Conversation

Yaqiang
Copy link
Contributor

@Yaqiang Yaqiang commented Mar 29, 2023 •
edited
Loading

Description of Changes

Add Grib2 template 4.60 Grib2Pds60 inner class to support s2s ensemble forecasting data of ECMWF.

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shahramn
Copy link

The correct name for this is:
Individual ensemble reforecast, control and perturbed, at a horizontal level or in a horizontal layer at a point in time

@Yaqiang
Copy link
Contributor Author

Yaqiang commented Mar 29, 2023

The correct name for this is: Individual ensemble reforecast, control and perturbed, at a horizontal level or in a horizontal layer at a point in time

Got it. By the way, the added template was verified using MeteoInfoLab with ECMWF S2S Grib2 data with the template 4.60.
ECMWF_S2S_grib2_template-4 60

Yaqiang and others added 2 commits June 5, 2023 13:16
@Yaqiang
add ensNumber to EnsCoordValue to read all ensemble members from grib…
5916ed7 
… file
@Yaqiang
add Grib2 template 4.60 Grib2Pds60 inner class to support s2s ensembl…
9813f88 
…e forecasting data of ECMWF, and overload EnsCoorValue constructor with ensNumber parameter to read all members with save pertubation number
haileyajohnson
haileyajohnson reviewed Jun 5, 2023
View reviewed changes
grib/src/main/java/ucar/nc2/grib/collection/GribCollectionBuilderFromIndex.java
@@ -432,7 +432,7 @@ else if (isRegular)
for (int i = 0; i < pc.getValuesCount(); i++) {
double val1 = pc.getValues(i);
double val2 = pc.getBound(i);
ecoords.add(new EnsCoordValue((int) val1, (int) val2));
ecoords.add(new EnsCoordValue((int) val1, (int) val2, i + 1));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sort of a dummy coord, isn't it? Can we just leave out the i+1? Other than that I think this all looks good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is sort of a dummy coord. i + 1 was used because no better choice on my side.

@haileyajohnson
Copy link

you will also need to apply code style to get the checks to pass: ./gradlew spotlessJavaApply

@haileyajohnson haileyajohnson mentioned this pull request Jun 7, 2023
Merged
@haileyajohnson
Copy link

Moved to #1192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yaqiang @CLAassistant @shahramn @haileyajohnson