Add MFile method to create child MFile #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
force-pushed
the
mfile-resolve
branch
from
277c754
to
ccb0323
Compare
tdrwenski
force-pushed
the
mfile-resolve
branch
4 times, most recently
from
8e2017d
to
fb947d1
Compare
haileyajohnson
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The method added in the PR is needed for S3 DatasetScans and also if we want featureCollection indices in S3. The idea is that if we have a directory and want to get the file path of a file in that directory, we should let
MFilehandle that to avoid repeatedly parsing path strings (For S3 the separator could be "/" or "?" if its a bucket, and it also may have a fragment in the uri likecdms3:mybucket/dir#delimiter=/so appending/filename.ncor whatever doesn't work.)