Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception instead of assert(false) #1195

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Throw exception instead of assert(false) #1195

merged 1 commit into from
Jun 9, 2023

Conversation

tdrwenski
Copy link
Member

Description of Changes

The enable asserts option has been removed from our TDS servers, so it is best that we use exceptions and not asserts for error handling.

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@tdrwenski tdrwenski marked this pull request as ready for review June 9, 2023 16:43
@haileyajohnson haileyajohnson merged commit 8670281 into Unidata:maint-5.x Jun 9, 2023
9 checks passed
@tdrwenski tdrwenski deleted the change-asserts-to-exceptions branch June 9, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

@DennisHeimbigner DennisHeimbigner Awaiting requested review from DennisHeimbigner DennisHeimbigner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdrwenski @haileyajohnson