Fix nested structures in NcStream #1196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
If data had a structure within a structure, the inner structure's members wouldn't get set when read with the NcStreamReader (used by CdmRemote). This caused TDS integration test
thredds.server.cdmr.TestCdmRemoteCompareDataP.doOne[/share/testdata/cdmUnitTest/thredds-test-data/local/thredds-test-data/cdmUnitTest/formats/netcdf4/testNestedStructure.nc]
to fail with a nullptr exception. With this fix all the CdmRemote tests pass. There aren't any netcdf-java unit tests hitting this code as far as I could tell, but I ran the netcdf-java tests on Jenkins on this branch just in case.
PR Checklist
until ready for review