Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style fixes for ncml reader and test class #1207

Merged
merged 7 commits into from
Jul 7, 2023
Merged

Code style fixes for ncml reader and test class #1207

merged 7 commits into from
Jul 7, 2023

Conversation

tdrwenski
Copy link
Member

Description of Changes

  • style fixes for NcmlReader
  • Cleanups for TestNcmlRenameVar: use google truth asserts, remove try/catches

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@tdrwenski tdrwenski marked this pull request as ready for review July 6, 2023 22:27
@haileyajohnson haileyajohnson merged commit 5ea0fbb into Unidata:maint-5.x Jul 7, 2023
9 checks passed
@tdrwenski tdrwenski deleted the cleanups branch July 7, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdrwenski @haileyajohnson