Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zarr last modified #1288

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

tdrwenski
Copy link
Contributor

@tdrwenski tdrwenski commented Jan 17, 2024

Fix to zarr last modified function added in #1285 to avoid nullptr exception when cache is used. If the zarr file is put in the cache the raf is closed. For zarr, the raf (in this case RandomAccessDirectory) is the only class capable of computing the last modified correctly for zarr so we need to reacquire the raf to check this last modified. This is a bit sub optimal since the if the file is changed, the cache will reacquire the raf again.

Test added in TDS: Unidata/tds#450

@tdrwenski tdrwenski marked this pull request as ready for review January 17, 2024 23:13
@haileyajohnson haileyajohnson merged commit c2aa012 into Unidata:maint-5.x Jan 18, 2024
10 checks passed
@tdrwenski tdrwenski deleted the zarr-last-modified branch January 18, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants