Fix zarr last modified #1288
Merged
Fix zarr last modified #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to zarr last modified function added in #1285 to avoid nullptr exception when cache is used. If the zarr file is put in the cache the
rafis closed. For zarr, theraf(in this caseRandomAccessDirectory) is the only class capable of computing the last modified correctly for zarr so we need to reacquire therafto check this last modified. This is a bit sub optimal since the if the file is changed, the cache will reacquire therafagain.Test added in TDS: Unidata/tds#450