Improve S3 Zarr performance #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
commented
Jan 31, 2024
tdrwenski
force-pushed
the
improve-zarr-perf
branch
from
d63e99f
to
15a7c94
Compare
tdrwenski
force-pushed
the
improve-zarr-perf
branch
3 times, most recently
from
e2fb3aa
to
ee091c3
Compare
tdrwenski
force-pushed
the
improve-zarr-perf
branch
from
ee091c3
to
ffa73c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
There is no way to control the order of the IOSP classes loaded by the
ServiceLoader. This can result in very slow performance for S3 Zarr files, since many IOSPs will want to read the data to check if it is a valid file of their type. TheZarrIospcheck is super fast since it only needs to check whether its Raf is a directory type.I propose to add a new method to the
IOServiceProviderinterface that will sort the IOSPs into two (or later more) groups so that the fast/common IOSPs can be checked first and the rest checked later.